Split React.podspec into separate podspecs for each Xcode project #23559
+1,033
−429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the pods more closely match Xcode projects, where the CxxBridge, CxxModule and CxxUtils folders are a part of the main React.xcodeproj project.
facebook-github-bot
added
the
CLA Signed
orta
approved these changes
Feb 20, 2019
|
iOS platform is locked to 10.0, doesn't RN support minimal version 9.0 anymore? |
|
Yeah RN supports iOS 9, can we update that before landing? |
|
Target set to 9.0. |
WKWebView is not available on tvOS
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
a-dilettante
pushed a commit
to Skyscanner/react-native
that referenced
this pull request
Apr 16, 2019
…cebook#23559) Summary: This PR implements the first part of [RFC0004: CocoaPods Support Improvements](https://github.com/react-native-community/discussions-and-proposals/blob/353d44f64957113409eb16f836e23dba396a6b46/proposals/0004-cocoapods-support-improvements.md), splitting the `React.podspec` into separate podspecs to more closely match the structure of Xcode projects. The new structure aims to have one to one mapping between Xcode projects and podspecs. The only places where we differ from this mapping are: * `React/React-DevSupport.podspec`: `DevSupport` is a part of `React.xcodeproj`, which corresponds to the `React-Core` pod. However, we can't include it in the `React-Core` pod because `DevSupport` depends on `React-RCTWebSocket`, which depends on `React-Core`. Pods may not have circular dependencies. * The new pods under `ReactCommon/` don't have a corresponding `xcodeproj` because there are no `xcodproj` files in `ReactCommon/`. Those C++ modules are included in `React.xcodeproj`. *Next steps (not in scope of this PR):* - Start submitting the Podspecs to CocoaPods on a deploy (or turn the React Native repo into a spec repo): this is important in order to make the experience nicer for library consumers, so that it's not necessary to specify the local path of each Podspec in `Podfile`, you can just add `pod 'React', <version>`. - Add `Podfile` to the default project template (I have a PR ready for this, but because of bugs related to subspecs, it's blocked on this PR) [iOS] [Changed] - Split React.podspec into separate podspecs for each Xcode project Pull Request resolved: facebook#23559 Differential Revision: D14179326 Pulled By: cpojer fbshipit-source-id: 397a9c30b6b5d24f86c790057c71f0d403f56c3d
a-dilettante
pushed a commit
to Skyscanner/react-native
that referenced
this pull request
Apr 25, 2019
…cebook#23559) Summary: This PR implements the first part of [RFC0004: CocoaPods Support Improvements](https://github.com/react-native-community/discussions-and-proposals/blob/353d44f64957113409eb16f836e23dba396a6b46/proposals/0004-cocoapods-support-improvements.md), splitting the `React.podspec` into separate podspecs to more closely match the structure of Xcode projects. The new structure aims to have one to one mapping between Xcode projects and podspecs. The only places where we differ from this mapping are: * `React/React-DevSupport.podspec`: `DevSupport` is a part of `React.xcodeproj`, which corresponds to the `React-Core` pod. However, we can't include it in the `React-Core` pod because `DevSupport` depends on `React-RCTWebSocket`, which depends on `React-Core`. Pods may not have circular dependencies. * The new pods under `ReactCommon/` don't have a corresponding `xcodeproj` because there are no `xcodproj` files in `ReactCommon/`. Those C++ modules are included in `React.xcodeproj`. *Next steps (not in scope of this PR):* - Start submitting the Podspecs to CocoaPods on a deploy (or turn the React Native repo into a spec repo): this is important in order to make the experience nicer for library consumers, so that it's not necessary to specify the local path of each Podspec in `Podfile`, you can just add `pod 'React', <version>`. - Add `Podfile` to the default project template (I have a PR ready for this, but because of bugs related to subspecs, it's blocked on this PR) [iOS] [Changed] - Split React.podspec into separate podspecs for each Xcode project Pull Request resolved: facebook#23559 Differential Revision: D14179326 Pulled By: cpojer fbshipit-source-id: 397a9c30b6b5d24f86c790057c71f0d403f56c3d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the first part of RFC0004: CocoaPods Support Improvements, splitting the
React.podspecinto separate podspecs to more closely match the structure of Xcode projects.The new structure aims to have one to one mapping between Xcode projects and podspecs. The only places where we differ from this mapping are:
React/React-DevSupport.podspec:DevSupportis a part ofReact.xcodeproj, which corresponds to theReact-Corepod. However, we can't include it in theReact-Corepod becauseDevSupportdepends onReact-RCTWebSocket, which depends onReact-Core. Pods may not have circular dependencies.ReactCommon/don't have a correspondingxcodeprojbecause there are noxcodprojfiles inReactCommon/. Those C++ modules are included inReact.xcodeproj.Next steps (not in scope of this PR):
Podfile, you can just addpod 'React', <version>.Podfileto the default project template (I have a PR ready for this, but because of bugs related to subspecs, it's blocked on this PR)Changelog
[iOS] [Changed] - Split React.podspec into separate podspecs for each Xcode project
Test Plan
Ran
cd RNTester; pod install; open RNTesterPods.xcworkspaceand made sure the app builds and runs without errors.