[iOS] Keep placeholder attributes sync with text input text's attributes #23738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
[iOS] Keep placeholder attributes sync with text input text's attributes Add nil check for placeholder
zhongwuzw
force-pushed
the
add_letterSpacing_placeholder
branch
from
bcb255a to
37445f2
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhongwuzw in 65c014d. When will my fix make it into a release? | Upcoming Releases |
react-native-bot
added
Merged
This was referenced Mar 4, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2019
Summary: After #23738 , we can add more text attributes to placeholder, so now, let's update the calculation of placeholder size based on placeholder attributes. [iOS] [Fixed] - Fixed multiline text input placeholder size Pull Request resolved: #23742 Differential Revision: D14320489 Pulled By: cpojer fbshipit-source-id: 6b0f07fe7406d5c99c7280d584f8b8e51fc84c00
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2019
Summary: After #23738 , we can add more text attributes to placeholder, so now, let's update the calculation of placeholder size based on placeholder attributes. [iOS] [Fixed] - Fixed singleline text input placeholder size Pull Request resolved: #23745 Differential Revision: D14320630 Pulled By: cpojer fbshipit-source-id: 2d9e8b59ba70228202add762cfc9c6cbc77e5e95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to keep placeholder attributes sync with text input's text attributes, like
font,kern....., to keep style the same.Also fixes #19002 .
Changelog
[iOS] [Fixed] - Keep placeholder attributes sync with text input text's attributes
Test Plan
When text input has style attributes like
letterSpacing,font, they also applied to placeholder text attributes.