Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: [Android] Error: Duplicate resources #22234 #23850

Closed
wants to merge 1 commit into from
Closed

Fixed: [Android] Error: Duplicate resources #22234 #23850

wants to merge 1 commit into from

Conversation

Ovi
Copy link

@Ovi Ovi commented Mar 11, 2019

Fixed error "Duplicate resources" while building APK file in Android

"[drawable-.../...]/.../android/app/src/main/res/drawable-mdpi/FILE [drawable-.../...] /.../android/app/build/generated/res/react/release/drawable-mdpi-v4/FILE: Error: Duplicate resources"

Summary

Changelog

Android Fixed - Fixed error "Duplicate resources" while building APK file in Android

Test Plan

Fixed error "Duplicate resources" while building APK file in Android

"[drawable-.../...]/.../android/app/src/main/res/drawable-mdpi/FILE [drawable-.../...] /.../android/app/build/generated/res/react/release/drawable-mdpi-v4/FILE: Error: Duplicate resources"
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the Platform: Android Android applications. label Mar 11, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 11, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@pull-bot
Copy link

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against e9a189e

@Ovi
Copy link
Author

Ovi commented Mar 12, 2019

Added Changelog

@dulmandakh
Copy link
Contributor

I think that folder names are hard coded, which won't work for flavors and targets. Could you please make it work with flavor and target configurations.

@cpojer
Copy link
Contributor

cpojer commented Mar 21, 2019

Hey @Ovi, do you mind addressing @dulmandakh's comments?

@Ovi
Copy link
Author

Ovi commented Mar 21, 2019

I think that folder names are hard coded, which won't work for flavors and targets. Could you please make it work with flavor and target configurations.

As far I have seen in many places that only "drawable-..." folder makes the issue while creating build.
@dulmandakh please let me know if you face this issue with any other file/folder.

@cpojer
Copy link
Contributor

cpojer commented May 9, 2019

Thanks for this! I'm going to merge #24518 which is based on your PR.

@cpojer cpojer closed this May 9, 2019
@Ovi Ovi deleted the patch-1 branch May 9, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants