Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixed template build gradle error on x86_64 #23897

Closed
wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary

Fixes #23893 . Fixes x86_64 apk build.

Changelog

[Android] [Fixed] - Fixed template build gradle error on x86_64

Test Plan

CI passes.

@react-native-bot react-native-bot added the Platform: Android Android applications. label Mar 13, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2019
@dulmandakh dulmandakh requested a review from cpojer March 13, 2019 14:24
@hramos
Copy link
Contributor

hramos commented Mar 13, 2019

The fact this issue has been in master for 2.5 months without it being caught is troublesome. Can you try adding a test to make sure we don't regress here in the future?

@zhongwuzw
Copy link
Contributor Author

@hramos Seem we have no way to build on x86_64. Please see https://circleci.com/docs/2.0/faq/#which-cpu-architectures-does-circleci-support.

@dulmandakh
Copy link
Contributor

I think we should add tests for the template, which will initialize a new project then build it for both Android and iOS. For Android, we can analyze APKs and check for dynamic libraries.

@grabbou
Copy link
Contributor

grabbou commented Mar 14, 2019

Right now, we manually test inited app - I guess we could factor in other architectures.

@dulmandakh
Copy link
Contributor

I think it's best to merge this PR and open an issue about template tests.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Mar 14, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 4aa731a.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added Merged This PR has been merged. and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants