-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fixed template build gradle error on x86_64 #23897
Conversation
The fact this issue has been in master for 2.5 months without it being caught is troublesome. Can you try adding a test to make sure we don't regress here in the future? |
@hramos Seem we have no way to build on |
I think we should add tests for the template, which will initialize a new project then build it for both Android and iOS. For Android, we can analyze APKs and check for dynamic libraries. |
Right now, we manually test inited app - I guess we could factor in other architectures. |
I think it's best to merge this PR and open an issue about template tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @zhongwuzw in 4aa731a. When will my fix make it into a release? | Upcoming Releases |
Summary
Fixes #23893 . Fixes x86_64 apk build.
Changelog
[Android] [Fixed] - Fixed template build gradle error on x86_64
Test Plan
CI passes.