-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] [added] - add more iOS flags into AccessibilityInfo #23913
[iOS] [added] - add more iOS flags into AccessibilityInfo #23913
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @elucaswork in 40de049. When will my fix make it into a release? | Upcoming Releases |
Summary
As a follow-up to this other PR #23839, it adds support for other, iOS only, flags into
AccessibilityInfo
.Changelog
It adds these other 4 methods:
isBoldTextEnabled()
isGrayscaleEnabled()
isInvertColorsEnabled()
isReduceTransparencyEnabled()
P.S: Android implementation for those methods just return
false
(withPromise.resolve(false)
)And the corresponding event listeners:
boldTextChanged
grayscaleChanged
,invertColorsChanged
,reduceTransparencyChanged
Test Plan
isBoldTextEnabled
andisReduceTransparencyEnabled
can be tested on iOS Simulator, by enabling the respective flags in Settings > General > AccessibilityFor
isInvertColorsEnabled
andisReduceTransparencyEnabled
only on iOS device. iOS Simulator's accessibility is just a subset of device's one. To test those two flags:Documentation PR: facebook/react-native-website#835