Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] JSStackTrace -> Ensure lineNumber exists before consuming #24399

Closed
wants to merge 1 commit into from
Closed

[android] JSStackTrace -> Ensure lineNumber exists before consuming #24399

wants to merge 1 commit into from

Conversation

Salakar
Copy link
Contributor

@Salakar Salakar commented Apr 10, 2019 •
edited
Loading

Summary

Fixes #24382

Changelog

[ANDROID] [INTERNAL] - Fixed a NoSuchKeyException when parsing JS stack frames without line numbers.

Test Plan

TODO: Will update tomorrow (sorry 🙈) just wanted to check CI.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 10, 2019
@pull-bot
Copy link

Messages
📖

📋 Changelog Format - Did you include a Changelog? A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against ee38bb1

@Salakar Salakar mentioned this pull request Apr 10, 2019
Closed
@react-native-bot react-native-bot added the Platform: Android Android applications. label Apr 10, 2019
@cpojer
Copy link
Contributor

cpojer commented Apr 11, 2019

Very nice fix, thank you so much @Salakar!

facebook-github-bot
facebook-github-bot approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Salakar in c953e0b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 11, 2019
evgeni-wix pushed a commit to wix-playground/react-native that referenced this pull request Apr 11, 2019
@Salakar @evgeni-wix
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
93ffe02 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
dsyang pushed a commit to dsyang/react-native that referenced this pull request Apr 12, 2019
@Salakar @dsyang
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
7906059 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
@mattijsf
Copy link
Contributor

As this fixes broken JS crash handling I personally I think this is worth shipping in a 0.59.5 release on a short notice.

grabbou pushed a commit that referenced this pull request Apr 17, 2019
@Salakar @grabbou
JSStackTrace -> Ensure lineNumber exists before consuming (#24399)
d7bd6cc 
Summary:
Fixes #24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: #24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
@tonmanayo tonmanayo mentioned this pull request Apr 18, 2019
Closed
karanjthakkar pushed a commit to karanjthakkar/react-native that referenced this pull request May 10, 2019
@Salakar @karanjthakkar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
87d7035 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
karanjthakkar pushed a commit to karanjthakkar/react-native that referenced this pull request May 10, 2019
@Salakar @karanjthakkar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
639392d 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
@zhigang1992 zhigang1992 mentioned this pull request May 12, 2019
Closed
randy-miller pushed a commit to ubiquity6/react-native that referenced this pull request Jul 29, 2019
@Salakar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
7bccbc4 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
randy-miller added a commit to ubiquity6/react-native that referenced this pull request Jul 29, 2019
@randy-miller
Merge pull request #3 from ubiquity6/randy/fix-logs-3
a630a3c 
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#24399)
randy-miller pushed a commit to ubiquity6/react-native that referenced this pull request Jul 29, 2019
@Salakar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
3ec350f 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
randy-miller added a commit to ubiquity6/react-native that referenced this pull request Jul 29, 2019
@randy-miller
Merge pull request #4 from ubiquity6/randy/fix-logs-on-u6_dev
9a60849 
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#24399)
randy-miller pushed a commit to ubiquity6/react-native that referenced this pull request Jul 29, 2019
@Salakar
JSStackTrace -> Ensure lineNumber exists before consuming (facebook#2…
1e9acee 
…4399)

Summary:
Fixes facebook#24382

[ANDROID] [INTERNAL] - Fixed a `NoSuchKeyException` when parsing JS stack frames without line numbers.
Pull Request resolved: facebook#24399

Differential Revision: D14890746

Pulled By: cpojer

fbshipit-source-id: cea3653076484ad624084c370439f8a39c303083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on reportSoftException when lineNumber is missing
6 participants
@Salakar @pull-bot @cpojer @react-native-bot @mattijsf @facebook-github-bot