-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed incorrect opacity behaviour for <Text> component on iOS #24435
Conversation
Fixed incorrect opacity behaviour for <Text> component on iOS
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @shergin! Thank you so much for sending a pull request. I guess we can merge it but next time please include a test plan :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @shergin in d99e657. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR fixes #24229. Seems currently `opacity` props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text. [CATEGORY] [TYPE] - Fixed double applying opacity prop for Text Pull Request resolved: #24435 Differential Revision: D14932795 Pulled By: cpojer fbshipit-source-id: f9280fc75f788424cb5f1e42d2e79efdb354d645
Summary
This PR fixes #24229.
Seems currently
opacity
props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text.Changelog
[CATEGORY] [TYPE] - Fixed double applying opacity prop for Text
Test Plan
See #24229 for more details.