[iOS] Fix nullability warnings in RCTExceptionsManager #24467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
5 tasks
cpojer
approved these changes
Apr 17, 2019
facebook-github-bot
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @jtreanor in 31850df. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
May 6, 2019
Summary: There are a number of nullability warnings in `RCTExceptionsManager` when building React Native for iOS with Xcode 10.2. This resolves them without changing the existing behavior. See the warnings here:  [iOS] [Fixed] - Fix nullability warnings in RCTExceptionsManager Pull Request resolved: #24467 Differential Revision: D14973485 Pulled By: cpojer fbshipit-source-id: 2fac9f067ac9418397c3913760a2403f9a2cc147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are a number of nullability warnings in
RCTExceptionsManagerwhen building React Native for iOS with Xcode 10.2. This resolves them without changing the existing behavior.See the warnings here:
Changelog
[iOS] [Fixed] - Fix nullability warnings in RCTExceptionsManager
Test Plan
React.xcodeprojwith Xcode 10.2.