bump Gradle to 5.4.1 #24542
Closed
bump Gradle to 5.4.1 #24542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
@gengjiawen @hey99xx what is you opinion about JVM options changes? |
|
why change the jvm options ? |
|
./gradlew wrapper task did change it |
Salakar
approved these changes
Apr 20, 2019
gengjiawen
approved these changes
Apr 22, 2019
I tried the change locally, works as expected. |
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in 6976a93. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Jun 5, 2019
Summary: Bump Gradle to 5.4.1, includes many improvements and fixes. [Android] [Changed] - Bump Gradle to 5.4.1 Pull Request resolved: #24542 Differential Revision: D15107106 Pulled By: hramos fbshipit-source-id: aeae0413a720466f1eef00ad8e80d59c406ecd80 # Conflicts: # template/android/gradle/wrapper/gradle-wrapper.jar
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Sep 11, 2019
Summary: Bump Gradle to 5.4.1, includes many improvements and fixes. [Android] [Changed] - Bump Gradle to 5.4.1 Pull Request resolved: facebook/react-native#24542 Differential Revision: D15107106 Pulled By: hramos fbshipit-source-id: aeae0413a720466f1eef00ad8e80d59c406ecd80 # Conflicts: # template/android/gradle/wrapper/gradle-wrapper.jar
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump Gradle to 5.4.1, includes many improvements and fixes.
Changelog
[Android] [Changed] - Bump Gradle to 5.4.1
Test Plan
RNTester is running as expected.