[iOS][Bug] - fix crash on performance logger #24821
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| #import <Foundation/Foundation.h> | |||
|
|
|||
| // Keep this in sync with _labelsForTags | |||
There was a problem hiding this comment.
I think we'd better to remove these missing labels in _labelForTags? because we don't use these enums at all.
|
@zhigang1992 could you make the change that was suggested by @zhongwuzw? |
…rfMonitorCrash # Conflicts: # React/Base/RCTPerformanceLogger.h # React/Base/RCTPerformanceLogger.m
|
All the unused flags are now removed except |
We can keep it, don't break |
There was a problem hiding this comment.
@PeteTheHeat is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @zhigang1992 in 5d3d398. When will my fix make it into a release? | Upcoming Releases |
Summary: Fix Issue facebook#24820 It's caused by `_labelsForTags` and `RCTPLTag` being out of sync, the crash might only be one of the issues that this bug was causing. ## Changelog [iOS] [Fixed] - fix crash on performance logger Pull Request resolved: facebook#24821 Differential Revision: D15407291 Pulled By: PeteTheHeat fbshipit-source-id: c8d2a047fceb9cec981c48fe5181d1b4cbf0976c
Summary
Fix Issue #24820
It's caused by
_labelsForTagsandRCTPLTagbeing out of sync, the crash might only be one of the issues that this bug was causing.Changelog
[iOS] [Fixed] - fix crash on performance logger
Test Plan
It should not crash