Correctly bypass sync calls in UIManager during remote debugging

[statm]

Summary

Remote debugging stopped working (since 0.58, according to #23254). See #23254 (comment) for repro steps.

The root cause is incorrect checks for Chrome debugging environment in UIManager.js.

• In one place where sync function lazilyLoadView should be avoided, we effectively use if (__DEV__ && !global.nativeCallSyncHook) to check remote debugging, which misses ship flavor (i.e. __DEV__ is false).
• In another place where we want to pre-populate view managers' constants to avoid calling sync function getConstantsForViewManager, if (__DEV__) is used, also missing ship flavor.

This PR fixes both checks, only using the absense of global.nativeCallSyncHook to determine remote debugging environments.

Changelog

[JavaScript] [Fixed] - Correctly bypass sync calls in UIManager during remote debugging

Test Plan

(Copying repro steps from #23254 (comment))

On a freshly created project by react-native-cli in android:

1. Shake phone -> Dev Settings -> Uncheck JS Dev Mode and Use JS Deltas. Then back.
2. Shake phone -> Turn on Debug JS Remotely. Then back
3. Reload

Current behavior: Invariant Violation: requireNativeComponent: "RCTView" was not found in the UIManager.

Fixed (expected) behavior: No errors, app executes correctly.

[cpojer]

Thank you for this PR. I think this should be fine.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Something is wrong with our Facebook infra, retrying…

[facebook-github-bot]

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @statm in 417e191.

^{When will my fix make it into a release? | Upcoming Releases}