-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fixes iOS packager connection not work #25803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @TheSavior
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
It seems like the existing definition is the one that works for internal use cases at FB, and the change you made for open source. I'm not sure how to resolve, cc @sammy-SC. |
This pull request was successfully merged by @zhongwuzw in 4ab9da1. When will my fix make it into a release? | Upcoming Releases |
Thanks for tracking this down and fixing it! |
Summary
Macro
ENABLE_PACKAGER_CONNECTION
invalid because of__has_include
can't find the header now. Leads to packager connection not work anymore.Changelog
[iOS] [Fixed] - Fixes iOS packager connection not work
Test Plan
curl http://localhost:8081/reload
in terminal. Reload operation can execute.