Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixes iOS packager connection not work #25803

Closed
wants to merge 1 commit into from
Closed

[iOS] Fixes iOS packager connection not work #25803

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary

Macro ENABLE_PACKAGER_CONNECTION invalid because of __has_include can't find the header now. Leads to packager connection not work anymore.

Changelog

[iOS] [Fixed] - Fixes iOS packager connection not work

Test Plan

  1. Init a new project.
  2. Run and input curl http://localhost:8081/reload in terminal. Reload operation can execute.

@zhongwuzw zhongwuzw requested a review from elicwhite July 24, 2019 08:21
@zhongwuzw zhongwuzw requested a review from shergin as a code owner July 24, 2019 08:21
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2019
@react-native-bot react-native-bot added Platform: iOS iOS applications. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used. Bug labels Jul 24, 2019
cpojer
cpojer approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @TheSavior

👍

facebook-github-bot
facebook-github-bot approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@cpojer
Copy link
Contributor

cpojer commented Jul 24, 2019

It seems like the existing definition is the one that works for internal use cases at FB, and the change you made for open source. I'm not sure how to resolve, cc @sammy-SC.

@zhongwuzw
Copy link
Contributor Author

zhongwuzw commented Jul 24, 2019 •
edited
Loading

@cpojer This works in internal at FB like below? add an OR statement.

#if RCT_DEV && (__has_include("RCTPackagerConnection.h") || __has_include(<React/RCTPackagerConnection.h>)) && !TARGET_OS_UIKITFORMAC

cc @sammy-SC ^

@elicwhite elicwhite mentioned this pull request Jul 24, 2019
Closed
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 4ab9da1.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 24, 2019
@elicwhite
Copy link
Member

Thanks for tracking this down and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpojer cpojer cpojer approved these changes

@elicwhite elicwhite elicwhite approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications. Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhongwuzw @cpojer @react-native-bot @elicwhite @facebook-github-bot