Change console error to warning for untracked touch end event #26170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ascorbic Thanks! |
|
@osdnk I think the only proper fix would be to fix the bug in the vendors' Android builds. This PR fixes an inconsistency in how we handle touch event errors so that OS bugs like these don't crash the app. |
|
@ascorbic we sync React into React Native. This code is part of React itself. Do you mind opening a PR to React first? |
|
@cpojer Oh right! I was confused by the |
|
I've opened facebook/react#16750 to address this |
|
I merged the other PR into React and we'll be syncing it into React Native soon on our own. Thank you so much! |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently if more touch end events are received than tracked touches, the app will crash with a
console.error. This PR changes the error to aconsole.warn, which matches other touch event errors. This fixes #15059, where an OS bug in certain Android devices means only two touchstart events, but three touchcancel events are received when performing a three finger screenshot gesture.Changelog
[General] [Fixed] - Change error to warning for untracked touch end event
Test Plan
On a device listed in #15059, enable three-finger screenshots. Open the RNTester app and perform three-finger screenshot gesture. Observe YellowBox warning for
"Ended a touch event which was not counted in 'trackedTouchCount'".Tested on a OnePlus 6 running Android 9.