[Nav] Add support for bar button icons and left buttons #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
force-pushed
the
nav-buttons
branch
2 times, most recently
from
7bbe3f7
to
63dbe44
Compare
| @@ -1123,6 +1123,12 @@ - (NSDictionary *)customBubblingEventTypes | |||
| @"captured": @"onNavigationCompleteCapture" | |||
| } | |||
| }, | |||
| @"topNavLeftButtonTap": @{ | |||
There was a problem hiding this comment.
We should migrate these out of RCTUIManager at some point - they should probably be regular event emitter stuff.
|
cc @ericvicenti as well. |
|
Updated to use RCT_CUSTOM_VIEW_PROPERTY. I left the nav event in RCTUIManager for now, but was thinking they eventually belong in one of the RCTNav*Manager files. |
facebook-github-bot
added
the
CLA Signed
ide
force-pushed
the
nav-buttons
branch
4 times, most recently
from
0137261
to
36745d3
Compare
reactjs-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
It will be awesome if this feature is merged :) |
ide
force-pushed
the
nav-buttons
branch
2 times, most recently
from
50b6283
to
1428c3e
Compare
NavigatorIOS supports four new properties:
- **rightButtonImageSource:** The source of an image to display in the top right. This must be a static image since UINavigationController only supports UIImages. Adding support for UIImageViews (or arbitrary views) is more complicated because custom views do not fade on touch and do not have hit slop the same way that UIImage buttons do. Usage: `rightButtonImageSource: ix('ImageName')`
- **backButtonImageSource:** Use a custom image for the back button. This does not replace the back caret (`<`) but instead replaces the text next to it.
- **leftButtonTitle**: Text for the left nav button, which supersedes the previous nav item's back button when specified. The main use case for this is your initial screen/UIVC which has nothing to go back to (since it is the first VC on the stack) but need to display a left button. This does hide the back button if there would have been one otherwise.
- **leftButtonImageSource:** Image source for the left button, supersedes the left button title.
Added UIExplorer example to demonstrate.
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Mar 26, 2020
* remove a stale event from the native tracking queue that prevents every other click from registering * comment change inline
jfrolich
pushed a commit
to jfrolich/react-native
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavigatorIOS supports four new properties:
rightButtonImageSource: ix('ImageName')<) but instead replaces the text next to it.Added UIExplorer example to demonstrate.