-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the android gitignore to sample app #2687
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
@@ -21,6 +21,12 @@ DerivedData | |||
*.ipa | |||
*.xcuserstate | |||
|
|||
# Android/IJ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest Android Studio uses this instead:
*/.idea/workspace.xml
*/.idea/libraries
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Is this change ignoring anything that is not already covered by .gitignore in the root directory https://github.com/facebook/react-native/blob/master/.gitignore ? |
Right.. this should go under _gitignore instead. |
Oh, sorry. I'm missed _gitignore file. :| |
@jhen0409 Do you want to update this PR or send a new one? |
No description provided.