Fix setting keyboardType from breaking autoCapitalize #27523

safaiyeh · 2019-12-16T01:25:23Z

Summary

Fix for #27510.

Setting the InputType.TYPE_CLASS_TEXT flag when keyboardType is null or default breaks autoCapitalize. Handle the case when keyboardType is null, default, or invalid type.

Changelog

[Android] [Fixed] - Fix setting keyboardType from breaking autoCapitalize

Test Plan

Added keyboardType prop to RNTester as so

<TextInput autoCapitalize="words" keyboardType="default" style={styles.default} />

facebook-github-bot

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

safaiyeh · 2019-12-17T16:33:59Z

Any action items from me for the Facebook Internal - Linter?

elicwhite · 2019-12-17T22:54:33Z

I think this needs someone internal (likely @JoshuaGross) to run the formatter internally and reland.

ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

facebook-github-bot

@JoshuaGross has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

react-native-bot · 2020-01-07T22:20:06Z

This pull request was successfully merged by @safaiyeh in 233fdfc.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: A previous PR broke toggling between visible and non-visible password (basically once a password field was made visible, future updates to the keyboardType were effectively ignored, so the password would always be visible). Original PR: #27523 Changelog: [Internal] Reviewed By: mdvacca, rodrigos-facebook Differential Revision: D19527245 fbshipit-source-id: a5ab343c8a0c6a608171dbfa5afc7536ff241826

JoshuaGross · 2020-01-23T03:01:19Z

@safaiyeh, please see this commit and verify that autoCapitalize still works for your test case here.

26d5faf

safaiyeh · 2020-01-24T01:59:21Z

I'll check this out tomorrow @JoshuaGross, would adding an E2E test for it be helpful?

safaiyeh · 2020-01-27T21:32:17Z

@JoshuaGross Just tested and confirm it works for 26d5faf.

JoshuaGross · 2020-03-03T00:38:15Z

@safaiyeh E2E tests would be great!

Summary: Fix for #27510. Setting the `InputType.TYPE_CLASS_TEXT` flag when `keyboardType` is null or default breaks autoCapitalize. Handle the case when `keyboardType` is null, default, or invalid type. ## Changelog [Android] [Fixed] - Fix setting keyboardType from breaking autoCapitalize Pull Request resolved: #27523 Test Plan: Added keyboardType prop to RNTester as so ``` <TextInput autoCapitalize="words" keyboardType="default" style={styles.default} /> ``` ![fixedKeyboardType](https://user-images.githubusercontent.com/8675043/70872892-c96dec80-1f5f-11ea-8e33-714a67eff581.gif) Reviewed By: makovkastar Differential Revision: D19132261 Pulled By: JoshuaGross fbshipit-source-id: be66f0317ed305425ebcff32046ad4bff06d367f

vongohren · 2020-03-06T23:06:24Z

@safaiyeh @JoshuaGross when is it worth thinking this fix will make it into the codebase? I dont see it with the 0.62.x RC

safaiyeh · 2020-03-06T23:34:12Z

@vongohren @alloy is managing the release, the RC discussion will determine that.

Also if this is picked, this commit: 26d5faf also must be picked due to a regression this caused.

vongohren · 2020-03-06T23:49:20Z

@safaiyeh I tried asking in the RC discussion, but I was ignored. So just asking here to find some more insight

alloy · 2020-03-06T23:57:01Z

233fdfc was identified by react-native-community/releases#157 (comment), which was picked.

@safaiyeh Are you saying that 26d5faf is essential for your change [that I picked] to work right?

safaiyeh · 2020-03-07T01:00:11Z

@alloy yup! It fixes a regression caused by this PR

alloy · 2020-03-07T07:35:00Z

Sigh, so that means RC4 is broken :( Thanks for the info!

Summary: A previous PR broke toggling between visible and non-visible password (basically once a password field was made visible, future updates to the keyboardType were effectively ignored, so the password would always be visible). Original PR: facebook#27523 Changelog: [Internal] Reviewed By: mdvacca, rodrigos-facebook Differential Revision: D19527245 fbshipit-source-id: a5ab343c8a0c6a608171dbfa5afc7536ff241826

Summary: Fix for facebook#27510. Setting the `InputType.TYPE_CLASS_TEXT` flag when `keyboardType` is null or default breaks autoCapitalize. Handle the case when `keyboardType` is null, default, or invalid type. ## Changelog [Android] [Fixed] - Fix setting keyboardType from breaking autoCapitalize Pull Request resolved: facebook#27523 Test Plan: Added keyboardType prop to RNTester as so ``` <TextInput autoCapitalize="words" keyboardType="default" style={styles.default} /> ``` ![fixedKeyboardType](https://user-images.githubusercontent.com/8675043/70872892-c96dec80-1f5f-11ea-8e33-714a67eff581.gif) Reviewed By: makovkastar Differential Revision: D19132261 Pulled By: JoshuaGross fbshipit-source-id: be66f0317ed305425ebcff32046ad4bff06d367f

Summary: A previous PR broke toggling between visible and non-visible password (basically once a password field was made visible, future updates to the keyboardType were effectively ignored, so the password would always be visible). Original PR: facebook#27523 Changelog: [Internal] Reviewed By: mdvacca, rodrigos-facebook Differential Revision: D19527245 fbshipit-source-id: a5ab343c8a0c6a608171dbfa5afc7536ff241826

Fix setting keyboardType from breaking autoCapitalize

aeabc1d

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 16, 2019

safaiyeh mentioned this pull request Dec 16, 2019

TextInput autoCapitalize="words" not working when keyboardType prop is passed on Android #27510

Closed

react-native-bot added API: Keyboard Bug Platform: Android Android applications. labels Dec 16, 2019

Jason Safaiyeh added 3 commits December 15, 2019 17:52

Handle case of other text keyboardTypes & unsupported types

e35f632

Cleanup static array

2dafbea

Remove the default type

34a0e5f

elicwhite requested a review from JoshuaGross December 16, 2019 23:01

facebook-github-bot reviewed Dec 16, 2019

View reviewed changes

makovkastar reviewed Dec 19, 2019

View reviewed changes

ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java Outdated Show resolved Hide resolved

ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java Outdated Show resolved Hide resolved

Jason Safaiyeh and others added 2 commits December 19, 2019 16:24

Clean up logic

ba03ed2

Update comment for keyboardType else

bcb1836

facebook-github-bot reviewed Dec 20, 2019

View reviewed changes

facebook-github-bot closed this in 233fdfc Jan 7, 2020

react-native-bot added the Merged This PR has been merged. label Jan 7, 2020

vongohren mentioned this pull request Feb 27, 2020

0.62.x RC Discussion react-native-community/releases#157

Closed

6 tasks

safaiyeh mentioned this pull request Mar 9, 2020

E2E for keyboardType breaking autoCapitalize #28267

Closed

safaiyeh mentioned this pull request Apr 22, 2020

🐛 [Android][TextInput] when combine secureTextEntry + autoCapitalize props #28709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix setting keyboardType from breaking autoCapitalize #27523

Fix setting keyboardType from breaking autoCapitalize #27523

safaiyeh commented Dec 16, 2019 •

edited

Loading

facebook-github-bot left a comment

safaiyeh commented Dec 17, 2019

elicwhite commented Dec 17, 2019

facebook-github-bot left a comment

react-native-bot commented Jan 7, 2020

JoshuaGross commented Jan 23, 2020

safaiyeh commented Jan 24, 2020

safaiyeh commented Jan 27, 2020

JoshuaGross commented Mar 3, 2020

vongohren commented Mar 6, 2020

safaiyeh commented Mar 6, 2020 •

edited

Loading

vongohren commented Mar 6, 2020

alloy commented Mar 6, 2020 •

edited

Loading

safaiyeh commented Mar 7, 2020

alloy commented Mar 7, 2020

Fix setting keyboardType from breaking autoCapitalize #27523

Fix setting keyboardType from breaking autoCapitalize #27523

Conversation

safaiyeh commented Dec 16, 2019 • edited Loading

Summary

Changelog

Test Plan

facebook-github-bot left a comment

Choose a reason for hiding this comment

safaiyeh commented Dec 17, 2019

elicwhite commented Dec 17, 2019

facebook-github-bot left a comment

Choose a reason for hiding this comment

react-native-bot commented Jan 7, 2020

JoshuaGross commented Jan 23, 2020

safaiyeh commented Jan 24, 2020

safaiyeh commented Jan 27, 2020

JoshuaGross commented Mar 3, 2020

vongohren commented Mar 6, 2020

safaiyeh commented Mar 6, 2020 • edited Loading

vongohren commented Mar 6, 2020

alloy commented Mar 6, 2020 • edited Loading

safaiyeh commented Mar 7, 2020

alloy commented Mar 7, 2020

safaiyeh commented Dec 16, 2019 •

edited

Loading

safaiyeh commented Mar 6, 2020 •

edited

Loading

alloy commented Mar 6, 2020 •

edited

Loading