Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save connection url as class variable #27702

Closed
wants to merge 1 commit into from
Closed

Conversation

sirpy
Copy link
Contributor

@sirpy sirpy commented Jan 7, 2020

Changelog

[General] [Fixed] - WebSocket now exposes url on instance

Test Plan

Simply console.log connection.url it should equal the original url used to make the websockets connection

Summary

Conform with Websocket javascript api.
related to web3js issues: web3/web3.js#2864 web3/web3.js#2602

Conform with Websocket javascript api
@facebook-github-bot
Copy link
Contributor

Hi sirpy! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Jan 7, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 7eb7e91

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@elicwhite
Copy link
Member

It looks like the behavior on web is to provide this value:

> var connection = new WebSocket('wss://html5rocks.websocket.org/echo', ['soap', 'xmpp']);
> console.log(connection.url)
wss://html5rocks.websocket.org/echo

Can you update your PR following the recommendations from #27702 (comment)?

@sirpy
Copy link
Contributor Author

sirpy commented Jan 12, 2020

@TheSavior
done

@ravi0the0sun
Copy link

hi is this PR going to be implemented as im having problems in my project as well

@luco
Copy link

luco commented Jan 2, 2021

Getting this as well.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yungsters
Copy link
Contributor

Closed via 8facc86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants