-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: save connection url as class variable #27702
Conversation
Conform with Websocket javascript api
Hi sirpy! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
It looks like the behavior on web is to provide this value:
Can you update your PR following the recommendations from #27702 (comment)? |
@TheSavior |
hi is this PR going to be implemented as im having problems in my project as well |
Getting this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Closed via 8facc86. |
Changelog
[General] [Fixed] - WebSocket now exposes url on instance
Test Plan
Simply console.log connection.url it should equal the original url used to make the websockets connection
Summary
Conform with Websocket javascript api.
related to web3js issues: web3/web3.js#2864 web3/web3.js#2602