Bring back support for Dialogs over non-FragmentActivity host #27790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
|
I'm not sure about FB opinion about supporting non-Fragment activities, @mdvacca please review. Thanks |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
Summary: Changelog: [Internal] This makes a couple objects more exact. Nothing critical, just noticed this old branch I had created when doing some Flow upgrades in the past. DiffTrain build for commit facebook/react@f498aa2. Reviewed By: hoxyq Differential Revision: D51824015 Pulled By: kassens fbshipit-source-id: ecadc98ffb233d6458c65c38150a29ff65a10121
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Changelog: [Internal] This makes a couple objects more exact. Nothing critical, just noticed this old branch I had created when doing some Flow upgrades in the past. DiffTrain build for commit facebook/react@f498aa2. Reviewed By: hoxyq Differential Revision: D51824015 Pulled By: kassens fbshipit-source-id: ecadc98ffb233d6458c65c38150a29ff65a10121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit had earlier (intentionally) stopped supporting DialogModule over non-FragmentActivity hosts.
The change was done for a genuine reason, but unfortunately, we have a number of brownfield clients within Microsoft who are finding it hard to change their host host activities in time, due to various reasons. As we expect the transition to take a while (Another 6 months), we would like to put back the support for legacy FragmentManager in DialogModule.
This change is an essential revert of the above mentioned commit.
Changelog
Bring back the support for legacy FragmentManager in DialogModule. This is required for brownfield applications who don't have ReactActivity as the host.
[CATEGORY] [TYPE] - Message
Test Plan