Add new DoNotStrip class to proguard config #27934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in cfcf5eb. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: JNI now comes from https://github.com/facebookincubator/fbjni and it uses a different DoNotStrip class (https://github.com/facebookincubator/fbjni/blob/master/java/com/facebook/jni/annotations/DoNotStrip.java) so we need to include it in the proguard config. ## Changelog [Android] [Fixed] - Add new DoNotStrip class to proguard config Pull Request resolved: facebook#27934 Test Plan: Test that it fixes a crash related to missing NativeRunnable class in release builds. Differential Revision: D19690580 Pulled By: cpojer fbshipit-source-id: cb4e2eaae35fb3a9d68f04c57cc973914207be73
alloy
pushed a commit
to alloy/react-native
that referenced
this pull request
Apr 3, 2020
Summary: JNI now comes from https://github.com/facebookincubator/fbjni and it uses a different DoNotStrip class (https://github.com/facebookincubator/fbjni/blob/master/java/com/facebook/jni/annotations/DoNotStrip.java) so we need to include it in the proguard config. ## Changelog [Android] [Fixed] - Add new DoNotStrip class to proguard config Pull Request resolved: facebook#27934 Test Plan: Test that it fixes a crash related to missing NativeRunnable class in release builds. Differential Revision: D19690580 Pulled By: cpojer fbshipit-source-id: cb4e2eaae35fb3a9d68f04c57cc973914207be73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JNI now comes from https://github.com/facebookincubator/fbjni and it uses a different DoNotStrip class (https://github.com/facebookincubator/fbjni/blob/master/java/com/facebook/jni/annotations/DoNotStrip.java) so we need to include it in the proguard config.
Changelog
[Android] [Fixed] - Add new DoNotStrip class to proguard config
Test Plan
Test that it fixes a crash related to missing NativeRunnable class in release builds.