[InputAccessoryView] Fix backgroundColor typing. #28105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Bug
Platform: iOS
|
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
|
RNTester.app (iOS): 10657792 bytes |
facebook-github-bot
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @alloy in a43fd60. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: TextInput’s `InputAccessoryView` was using a [deprecated] prop-type as a Flow type, which TheSavior asked me to fix [here](alloy/rn2dts@6ba4b28#r37343692). ## Changelog [iOS] [Fixed] - Fixes the `InputAccessoryView.backgroundColor` prop’s typing to use `ColorValue`. Pull Request resolved: facebook#28105 Test Plan: Passes: ```bash yarn flow-check-ios ``` Differential Revision: D19956401 Pulled By: TheSavior fbshipit-source-id: 0c16f292b0143e83235a23712a0a7a11b8317f4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TextInput’s
InputAccessoryViewwas using a [deprecated] prop-type as a Flow type, which @TheSavior asked me to fix here.Changelog
[iOS] [Fixed] - Fixes the
InputAccessoryView.backgroundColorprop’s typing to useColorValue.Test Plan
Passes: