-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JavaScript][Removed] - Remove leftover Incremental
component
#28107
Conversation
|
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
RNTester.app (iOS): 10657792 bytes |
@@ -94,6 +94,11 @@ export type Props = { | |||
}; | |||
type State = {doIncrementalRender: boolean, ...}; | |||
|
|||
const IncrementalContext = React.createContext<Context>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is not a context provider, but a consumer, so there's no need to create a new context here.
@TheSavior I guess this component is used internally at Facebook or it's some dead code that haven't been removed yet. Can you shed some information on the topic? If it can be removed, that's great. If not, we need to get the context from somewhere.
In previous versions of react-native we had components like Here is how it used to look like: |
Looks like a leftover from 0ef0d31. I assume you're safe to remove it |
Looks like it is a leftover from this commit: facebook@0ef0d31
RNTester (Android/hermes/arm64-v8a): 3289088 bytes |
Incremental
component
RNTester.app (iOS): 10657792 bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Yeah, this is unused! Yay. Thanks for deleting. |
I made a package with this if anyone is interested https://github.com/th3rdwave/react-native-incremental |
This pull request was successfully merged by @venits in e998002. When will my fix make it into a release? | Upcoming Releases |
Summary: 1/4 of facebook#28103 ## Changelog [JavaScript][Removed] - Remove leftover `Incremental` component. Pull Request resolved: facebook#28107 Test Plan: In RNTester `Incremental` component is no longer used so I modified one of existing examples to use it. Reviewed By: rickhanlonii Differential Revision: D19960536 Pulled By: TheSavior fbshipit-source-id: 791bda7138ac23916957577ed5f5c465c5e96299
Summary
1/4 of #28103
Changelog
[JavaScript][Removed] - Remove leftover
Incremental
component.Test Plan
In RNTester
Incremental
component is no longer used so I modified one of existing examples to use it.