Fix RequestBodyUtil for older version of Android (M or before) #28399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @daisy1754! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: eb83356 |
Base commit: 25f7aea |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
|
:/ it's sad that this is being ignored, IMO such a simple fix that fixes easy-to-reproduce crash |
github-actions
bot
removed
the
Stale
cortinico
force-pushed
the
feature/fix_request_body_util_m
branch
from
195f202 to
fb951fd
Compare
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in 4b39f44. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…ook#28399) Summary: This is bugfix for following code in RequestBodyUtil.java. ``` stream.getChannel().transferFrom(channel, 0, Long.MAX_VALUE); ``` This throws IllegalArgumentException in Android M or before. It seems in old version of JVM it internally casts third argument to integer so when you pass value that is larger than Integer.MAX_VALUE app would crash. See: https://bugs.openjdk.java.net/browse/JDK-5105464 https://stackoverflow.com/questions/55696035/thrown-illegalargumentexception-when-using-java-nio ## Changelog [Android] [Fixed] Fix issue downloading request body via remote URL Pull Request resolved: facebook#28399 Test Plan: Run following code on Android M or before. It would crash w/o this PR but it won't with this PR. ``` const body = new FormData(); const image = { uri: "https://reactnative.dev/img/showcase/facebook.png", path: null }; body.append('user[img]', fileBody(image)); fetch("https://example.com", { method: 'POST', headers: { Accept: 'application/json', 'Content-Type': 'multipart/form-data;', }, body: body }); ``` Reviewed By: christophpurrer, cipolleschi Differential Revision: D45057263 Pulled By: cortinico fbshipit-source-id: e0306eb157a5aa92619ac51e67d106b8651a0ba7
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…ook#28399) Summary: This is bugfix for following code in RequestBodyUtil.java. ``` stream.getChannel().transferFrom(channel, 0, Long.MAX_VALUE); ``` This throws IllegalArgumentException in Android M or before. It seems in old version of JVM it internally casts third argument to integer so when you pass value that is larger than Integer.MAX_VALUE app would crash. See: https://bugs.openjdk.java.net/browse/JDK-5105464 https://stackoverflow.com/questions/55696035/thrown-illegalargumentexception-when-using-java-nio ## Changelog [Android] [Fixed] Fix issue downloading request body via remote URL Pull Request resolved: facebook#28399 Test Plan: Run following code on Android M or before. It would crash w/o this PR but it won't with this PR. ``` const body = new FormData(); const image = { uri: "https://reactnative.dev/img/showcase/facebook.png", path: null }; body.append('user[img]', fileBody(image)); fetch("https://example.com", { method: 'POST', headers: { Accept: 'application/json', 'Content-Type': 'multipart/form-data;', }, body: body }); ``` Reviewed By: christophpurrer, cipolleschi Differential Revision: D45057263 Pulled By: cortinico fbshipit-source-id: e0306eb157a5aa92619ac51e67d106b8651a0ba7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is bugfix for following code in RequestBodyUtil.java.
This throws IllegalArgumentException in Android M or before. It seems in old version of JVM it internally casts third argument to integer so when you pass value that is larger than Integer.MAX_VALUE app would crash.
See:
https://bugs.openjdk.java.net/browse/JDK-5105464
https://stackoverflow.com/questions/55696035/thrown-illegalargumentexception-when-using-java-nio
Changelog:
[ANDROID] [FIXED] - Fix issue downloading request body via remote URL
Test Plan
Run following code on Android M or before. It would crash w/o this PR but it won't with this PR.