Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests to Xcode 11.3.1 #28501

Closed
wants to merge 6 commits into from
Closed

Upgrade tests to Xcode 11.3.1 #28501

wants to merge 6 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Apr 2, 2020

Summary:
Upgrade Sandcastle and Circle CI tests to use Xcode 11.4.0 across the board.

Changelog:
[Internal] - Use Xcode 11.4.0 in tests

Differential Revision: D20821844

hramos and others added 2 commits April 2, 2020 14:02
Summary:
Pull Request resolved: facebook#28498

Upgrade Sandcastle and Circle CI tests to use Xcode 11.4.0 across the board.

Changelog:
[Internal] - Use Xcode 11.4.0 in tests

Differential Revision: D20821844

fbshipit-source-id: 75dfe0549a4cb26c542a68cb54f29f1d1cdcc4c5
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team labels Apr 2, 2020
@pull-bot
Copy link

pull-bot commented Apr 2, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against b92658f

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,607,336 -113
android hermes armeabi-v7a 6,284,178 -129
android hermes x86 6,948,101 -97
android hermes x86_64 6,878,580 -102
android jsc arm64-v8a 8,915,609 -112
android jsc armeabi-v7a 8,555,795 -129
android jsc x86 8,740,406 -97
android jsc x86_64 9,317,111 -129

Base commit: 3ed1b1f

@analysis-bot
Copy link

analysis-bot commented Apr 2, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 10,843,984 48

Base commit: 3ed1b1f

@hramos hramos changed the title Upgrade tests to Xcode 11.4.0 Upgrade tests to Xcode 11.3.1 Apr 3, 2020
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 4, 2020
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 25836bc.

sasurau4 pushed a commit to sasurau4/react-native that referenced this pull request Apr 15, 2020
Summary:
Upgrade Sandcastle and Circle CI tests to use Xcode 11.3.1 across the board.

Pull Request resolved: facebook#28498
Pull Request resolved: facebook#28501

Changelog:
[Internal] - Use Xcode 11.3.1 in iOS tests

Reviewed By: fkgozali

Differential Revision: D20821844

fbshipit-source-id: b250ca82bdf2c9fb7faa765d3e2433eb46efd692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants