Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade eslint-config in template #28662

Conversation

Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Apr 17, 2020

Summary

Upgraded the eslint-config in template

Changelog

[General] [Changed] - Upgrade eslint-config in template to prepare for 0.63 release react-native-community/releases#186

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,759,491 0
android hermes armeabi-v7a 6,406,536 0
android hermes x86 7,140,890 0
android hermes x86_64 7,032,221 0
android jsc arm64-v8a 8,928,041 0
android jsc armeabi-v7a 8,567,481 0
android jsc x86 8,752,585 0
android jsc x86_64 9,329,519 0

Base commit: 90f60a8

@analysis-bot
Copy link

analysis-bot commented Apr 17, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 809,568 -9,850,496

Base commit: 90f60a8

@elicwhite
Copy link
Member

Ah, I thought I did this already, whoops.

Changing packages in package.jsons requires more work for us internally so we can't land the diffs that do this directly. I've put up this change internally though, so it should go through after review.

@elicwhite
Copy link
Member

This change landed in 780f06c

@elicwhite elicwhite closed this May 1, 2020
@Naturalclar Naturalclar deleted the chore/updateEslintConfigTemplate branch May 3, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants