Make sure LogBox is not included in production bundles #28984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 68c0edd |
Base commit: 68c0edd |
elicwhite
reviewed
May 29, 2020
| @@ -12,8 +12,6 @@ | |||
|
|
|||
| import Platform from '../Utilities/Platform'; | |||
| import RCTLog from '../Utilities/RCTLog'; | |||
| import * as LogBoxData from './Data/LogBoxData'; | |||
There was a problem hiding this comment.
This should be handled by the inline requires feature. We don't like manually inlining requires if we can avoid it.
There was a problem hiding this comment.
Sadly this is not enabled by default in OSS so I think doing it manually in this case is fine since it is not only for perf improvements.
There was a problem hiding this comment.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in d3b937f. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was doing some bundle inspection and noticed the LogBox module was included. It does amount to around 15kb so I think it is worth making sure it is not there.
To fix it I moved some imports to require inside DEV blocks to make sure metro is able to remove these imports.
Changelog
[General] [Fixed] - Make sure LogBox is not included in production bundles
Test Plan
Tested using react-native-bundle-visualizer and made sure nothing from LogBox was included in the bundle after these changes.