-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump Android Gradle Plugin to 4.0.0 #29044
Conversation
Base commit: 18f7aba |
Base commit: 18f7aba |
CC @fkgozali |
Hi @fkgozali, thanks for the reply! Just double checking, can you please confirm the order:
We can also close this PR (#29044), since AGP 4+ will be done in #29013 |
No, as previously discussed, let's not always take the latest without discussion. Re: 3/4, why not just go straight to 4.0.1 instead of 4.0.0, then 4.0.1? EDIT:
So yeah let's track 4+ with #29013 and close this PR. |
The force pushes were necessary to fix the history, so the history was changed, not destroyed. |
@rickhanlonii - Thanks for the reply! Maybe "destroyed" was not the right word, sorry about that. What I meant is that history was changed, i.e. the commits were overridden. Just curious: What kind of fix was necessary? |
@fkgozali let's merge this PR, and go ahead |
@dulmandakh - but there's already #29013 right? Shouldn't we just merge that one instead? |
I think we can settle on NDK version later on, and it might be better to move on with AGP. |
Yeah but the other PR also upgrades to 4.0.1, which one should I merge for now? cc @friederbluemle |
Summary: This is a major version update that needs to be tested thoroughly. Android Studio 4.0.1 is now available in the stable channel https://androidstudio.googleblog.com/2020/05/android-studio-40-available-in-stable.html https://developer.android.com/studio/releases/gradle-plugin#4.0.1 ## Changelog [Android] [Changed] - Update Android Gradle plugin to 4.0.1 Pull Request resolved: #29013 Test Plan: Build project Closes #29044 Reviewed By: shergin Differential Revision: D24041233 Pulled By: fkgozali fbshipit-source-id: 68ef0f313aa773866e65796e323ed0f19f41f834
Summary
Bump Android Gradle Plugin to 4.0.1, part of Android Studio 4.0 release.
Changelog
[Android] [Changed] - Bump Android Gradle Plugin to 4.0.1
Test Plan
RNTester builds and runs as expected. And my app with RN 0.63 builds and runs as expected.