-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix letters duplication when using autoCapitalize #29070
Closed
Closed
Changes from 22 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
677a789
fix capitalize characters and position cursor
fabOnReact 80ebff4
rename variable in java
fabOnReact 7e8eb41
adding test example to RNTester
fabOnReact a667188
changing text with setText
fabOnReact 04ce594
check for reactTextUpdate.length
fabOnReact bab02b5
Fix RNTester example
fabOnReact 784a210
remove console.log
fabOnReact 206fef9
Merge remote-tracking branch 'upstream/master' into fix-cursor-position
fabOnReact 85897b4
Merge remote-tracking branch 'upstream/master' into fix-cursor-position
fabOnReact 0d337da
fix eslint errors
fabOnReact bbe195a
Merge branch 'master' into fix-cursor-position
fabOnReact d28ac7b
update selection with maybeSetText
fabOnReact f8aea21
rn-tester - remove changes to examples
fabOnReact 76cd475
avoid increasing count when changing cursor Position
fabOnReact 1ec343b
update TextInput Example Title
fabOnReact 5957e59
Merge branch 'master' into fix-cursor-position
fabOnReact 3354c31
set mMaximumLength initial value to 0
fabOnReact 6490443
Merge branch 'master' into fix-cursor-position
fabOnReact 53c4868
Merge branch 'master' into fix-cursor-position
fabOnReact 532d772
Merge branch 'master' into fix-cursor-position
fabOnReact ae74063
Merge branch 'master' into fix-cursor-position
fabOnReact 8e7bd2e
Merge branch 'master' into fix-cursor-position
fabOnReact 8ac631e
Merge branch 'main' into fix-cursor-position
fabOnReact 7ecdea7
revert changes to maybeSetSelection
fabOnReact b86f498
use int insted of Integer
fabOnReact ec52724
Merge branch 'main' into fix-cursor-position
fabOnReact 6e6ab1b
Merge branch 'main' into fix-cursor-position
fabOnReact File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be Integer? The wrapped object Integer type has more overhead because the actual operations (less-than, etc) will first convert this to an
int
. Let's just useint
here instead and below as well if possible?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I'm reading changes from de44184 and re-evaluating this solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @JoshuaGross I added all the changes requested with b86f498 and I updated the PR summary with all the relevant information 🙏 Thanks a lot