feat: Enable Hermes to work on iOS #29914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
commented
Sep 9, 2020
grabbou
commented
Sep 9, 2020
grabbou
commented
Sep 9, 2020
facebook-github-bot
added
CLA Signed
alloy
reviewed
Sep 9, 2020
elicwhite
reviewed
Sep 9, 2020
Base commit: 36b0f7d |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
17 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
grabbou
commented
Sep 14, 2020
grabbou
commented
Sep 14, 2020
grabbou
commented
Sep 14, 2020
This comment has been minimized.
This comment has been minimized.
Summary: The nested `.gitattributes` file in `packages/react-native-codegen/android/` caused some confusion on Linux and macOS, causing Git to show `packages/react-native-codegen/android/gradlew.bat` as modified (CRLF removed, LF added). Instead of relying on repo-local `.gitattributes` files to convert endings in the working directory, the files should be committed to source control with the correct line endings in the first place. There is no reason to convert LF endings in .sh and many other file to CRLF on Windows (maybe this was an issue a long time ago, but unless Notepad is used this won't be a problem for practically all modern editors). Also fixed the line endings of `scripts/launchPackager.bat` which was incorrectly committed as LF. ## Changelog [Internal] [Fixed] - Line endings and .gitattributes Pull Request resolved: facebook#29792 Test Plan: Clone repo on Linux, macOS, and Windows, and make sure no modified files show up. Reviewed By: fkgozali Differential Revision: D23546135 Pulled By: mdvacca fbshipit-source-id: 1572fcb959212f212b137066f1aa66f0bb6e86c3
This comment has been minimized.
This comment has been minimized.
|
Just out of curiosity - has anyone done any benchmarks on hermes for iOS? |
This was referenced Mar 13, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it possible to build iOS applications with Hermes. Note that it doesn't work with
use_frameworks!just yet.Fixes #27845 (by downgrading iOS deployment target for RCT-Folly to 9.0)
Fixes #28810 (as above)
Checklist:
yarn linkits master to this project)i386to Hermes framework and enable BitcodeChangelog
[IOS] [FEATURE] - Enable Hermes on iOS
[INTERNAL] - Upgrade to CocoaPods 1.10.0 to resolve Xcode 12.0 issues
[INTERNAL] - Upgrade to Xcode 12.0 on the CircleCI
[INTERNAL] - Fix building RNTester in Release mode
[INTERNAL] - Fix build-time errors of
libeventwithuse_frameworks![INTERNAL] - Introduce
USE_HERMESvariable and test all RNTester configurations on the CI[INTERNAL] - Do not fetch CocoaPods repository since we're using CDN anyway
Test Plan
Turn on
hermes_enabledto true in yourPodfile, install pods, and run the iOS application. Your app should be running Hermes now.Preview: (note "Engine: Hermes")