bump fresco to 2.3.0 #30061
bump fresco to 2.3.0 #30061
Conversation
facebook-github-bot
added
CLA Signed
Base commit: 06ce643 |
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hmm actually, test_android failure seems related: Can you double check? |
|
It looks like failing to load native libraries, and I'm not good at Buck to resolve the issue. Could you please ask someone in FB for help. |
|
I'll find time to investigate next week, but expect some delay. |
|
I maintain a lot of repos and I dislike it when people just "bump" things, at the same time, I am sort of powerless to help on this one and I actually tried with a related PR :-), because I don't have access to the internal systems/logs. Any chance of investigation and merge on this one? Other than buck-related things this should work... |
|
@dulmandakh entropy is starting to take hold on this one, with a conflict |
|
Sorry I was quite swamped with the new architecture work for RNTester, I’ll try to pick this up again early next week. Any help figuring out the Buck issue would be very useful as well. |
|
I wonder if the failure above will self-resolve after resolving conflicts and re-pushing here. I say that because I noticed "KitKat" in the error and I believe minSdkVersion is 21 now, KitKat is 19. One can hope |
|
Yeah that’s possible, I was just thinking about that. @dulmandakh wanna try rebasing? |
|
Got it, will do soon |
|
So I looked into this a bit. This PR was days before the commit to bump test to run SDK 21: 7dcecb2 So to save time, I'm going to merge this PR and we'll fix forward any breakage after. |
|
Side note: testing this locally would require installing https://github.com/react-native-community/docker-android image locally, which is quite a big set up. |
|
This seems to pass: https://app.circleci.com/pipelines/github/facebook/react-native/7775/workflows/1b8515a7-bb5b-44ce-a404-674d04b828da/jobs/184957 So we're all good to go. |
|
Just in time for fresco 2.4.0 :-) |
Summary
Bump Fresco to 2.3.0.
Changelog
[Android] [Changed] - Bump Fresco to 2.3.0
Test Plan