Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React Native Robolectric 4.4 deps #30073

Closed
wants to merge 1 commit into from
Closed

Fix React Native Robolectric 4.4 deps #30073

wants to merge 1 commit into from

Conversation

jselbo
Copy link

@jselbo jselbo commented Sep 30, 2020

Differential Revision: D24009953

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 30, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D24009953

@pull-bot
Copy link

pull-bot commented Sep 30, 2020

Fails
🚫

❔ This pull request needs a description.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against df5b204

Summary:
Pull Request resolved: #30073

Changelog: [Android][Added] - Test infra: Robolectric 4.3.1 -> 4.4 upgrade

Differential Revision: D24009953

fbshipit-source-id: 4d55c680546ce74787b97c642548182f19e3570c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D24009953

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,372,881 0
android hermes armeabi-v7a 6,999,953 0
android hermes x86 7,813,381 0
android hermes x86_64 7,704,931 0
android jsc arm64-v8a 9,516,558 0
android jsc armeabi-v7a 9,135,766 0
android jsc x86 9,382,638 0
android jsc x86_64 9,963,548 0

Base commit: 1d89ef8

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Joshua Selbo in d373a8d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants