-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ReactFragmentActivity #30331
remove ReactFragmentActivity #30331
Conversation
Base commit: 017bc91 |
Base commit: 017bc91 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Actually, I just checked, we're still using this internally for other reasons. We could move it to just internal technically, but let's revisit a bit later? |
Nevermind, the removed file was just an empty abstract subclass of ReactActivity, so I updated our internal callsites. |
This pull request was successfully merged by @dulmandakh in 2798e71. When will my fix make it into a release? | Upcoming Releases |
Summary
Remove ReactFragmentActivity class, which was deprecated at least since 0.58.
Changelog
[Android] [Changed] - remove ReactFragmentActivity class.
Test Plan