Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java linting using google-java-format #30444

Closed
wants to merge 46 commits into from

Conversation

nganbread
Copy link
Contributor

@nganbread nganbread commented Nov 20, 2020

Summary

Adds google-java-format linting for all .java files in the ReactAndroid/ folder

Changelog

[Internal] [Added] - Linting for *.java files (google-java-format)

Test Plan

Locally

yarn lint-java --check
yarn lint-java --diff
yarn lint-java
yarn lint-ci

CI

#30512

@nganbread nganbread requested a review from hramos as a code owner November 20, 2020 15:55
@facebook-github-bot
Copy link
Contributor

Hi @nganbread!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Nov 20, 2020

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against cadbd11

@analysis-bot
Copy link

analysis-bot commented Nov 20, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 067d2ee

@analysis-bot
Copy link

analysis-bot commented Nov 20, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,520,977 -26
android hermes armeabi-v7a 7,105,844 -29
android hermes x86 7,961,267 -20
android hermes x86_64 7,872,755 -17
android jsc arm64-v8a 8,991,227 +0
android jsc armeabi-v7a 8,559,200 +0
android jsc x86 8,993,013 +0
android jsc x86_64 9,544,765 +0

Base commit: ae6f4f3

@nganbread nganbread requested a review from cpojer as a code owner November 20, 2020 17:44
bots/code-analysis-bot.js Outdated Show resolved Hide resolved
@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2020
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java Outdated Show resolved Hide resolved
bots/code-analysis-bot.js Show resolved Hide resolved
bots/code-analysis-bot.js Show resolved Hide resolved
scripts/lint-java.js Outdated Show resolved Hide resolved
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java Outdated Show resolved Hide resolved
bots/code-analysis-bot.js Show resolved Hide resolved
bots/code-analysis-bot.js Show resolved Hide resolved
scripts/lint-java.js Outdated Show resolved Hide resolved
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nganbread has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Dec 1, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nganbread has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @nganbread in defdb6d.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants