cleanup release.gradle #30468
Closed
cleanup release.gradle #30468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in a4d8632. When will my fix make it into a release? | Upcoming Releases |
Yep, this broke that 😂. |
marianeum
pushed a commit
to Skyscanner/react-native
that referenced
this pull request
Dec 20, 2021
Summary: Cleanup release.gradle and remove code used to upload RN to maven repository, which is not longer used. Also removed configuration to include Javadoc, Sources in maven repo, thus reduce NPM package size. ## Changelog [Internal] [Changed] - cleanup and remove maven upload from release.gradle Pull Request resolved: facebook#30468 Test Plan: you will no longer see *uploadArchives* in ./gradlew tasks. Also you can run **./gradlew :ReactAndroid:installArchives** Reviewed By: mdvacca Differential Revision: D25408128 Pulled By: fkgozali fbshipit-source-id: b3ced1b466b9f11e3970136a116af4e29dbd33a1
hsource
pushed a commit
to wanderlog/react-native
that referenced
this pull request
Apr 15, 2022
Summary: Cleanup release.gradle and remove code used to upload RN to maven repository, which is not longer used. Also removed configuration to include Javadoc, Sources in maven repo, thus reduce NPM package size. ## Changelog [Internal] [Changed] - cleanup and remove maven upload from release.gradle Pull Request resolved: facebook#30468 Test Plan: you will no longer see *uploadArchives* in ./gradlew tasks. Also you can run **./gradlew :ReactAndroid:installArchives** Reviewed By: mdvacca Differential Revision: D25408128 Pulled By: fkgozali fbshipit-source-id: b3ced1b466b9f11e3970136a116af4e29dbd33a1
hsource
pushed a commit
to wanderlog/react-native
that referenced
this pull request
Apr 18, 2022
Summary: Cleanup release.gradle and remove code used to upload RN to maven repository, which is not longer used. Also removed configuration to include Javadoc, Sources in maven repo, thus reduce NPM package size. ## Changelog [Internal] [Changed] - cleanup and remove maven upload from release.gradle Pull Request resolved: facebook#30468 Test Plan: you will no longer see *uploadArchives* in ./gradlew tasks. Also you can run **./gradlew :ReactAndroid:installArchives** Reviewed By: mdvacca Differential Revision: D25408128 Pulled By: fkgozali fbshipit-source-id: b3ced1b466b9f11e3970136a116af4e29dbd33a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup release.gradle and remove code used to upload RN to maven repository, which is not longer used. Also removed configuration to include Javadoc, Sources in maven repo, thus reduce NPM package size.
Changelog
[Internal] [Changed] - cleanup and remove maven upload from release.gradle
Test Plan
you will no longer see uploadArchives in ./gradlew tasks. Also you can run ./gradlew :ReactAndroid:installArchives