fix: update to @jest/create-cache-key-function@27 #30637

SimenB · 2020-12-23T17:40:45Z

Summary

API of Jest transformers is changing in Jest 27. The new version of @jest/create-cache-key-function handles both current versions of the API and the upcoming 27 API.

Ref: jestjs/jest#10834

Changelog

[Internal] [Changed] - Use version of @jest/create-cache-key-function compatible with upcoming Jest v27 release

Test Plan

I've tested locally that it works with both a jest@latest and jest@next release.

pull-bot · 2020-12-23T17:51:15Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ed4eee6

thymikee

👍🏼

SimenB · 2021-05-25T10:45:52Z

Unfortunate this hasn't made it in 6 months after I opened the PR... Anyways, 27 is released as latest now, so I've updated this PR

DoctorJohn · 2021-05-29T11:45:58Z

Is there anyone we could ping to get a review of this PR?

thymikee · 2021-05-31T09:17:41Z

Just pinged some folks, let's hope they can prioritize this. In the meantime, @SimenB would you mind resolving the conflict?

rickhanlonii

LGTM

facebook-github-bot · 2021-06-01T19:48:48Z

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-06-02T00:19:05Z

@hramos merged this pull request in 2f477b1.

Summary: CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we align the Windows config with the one for non-Windows jobs (in the `nodelts` executor) by running against the latest available Node v14 release. Changelog: [Internal] Differential Revision: D28896581 fbshipit-source-id: bd9dd3eb1921f7ab28f05088db23a54cf1a6478d

Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we align the Windows config with the one for non-Windows jobs (in the `nodelts` executor) by running against the latest available Node v14 release. Changelog: [Internal] Differential Revision: D28896581 fbshipit-source-id: ed490bcdae80e736338c387e255191d8be1888cb

Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we align the Windows config with the one for non-Windows jobs (in the `nodelts` executor) by running against the latest available Node v14 release. Changelog: [Internal] Differential Revision: D28896581 fbshipit-source-id: cdcf9341e265e3bf28457d3e91c26d76a1dbb82a

Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we pin a v14 release that is currently the most recent LTS version. NOTE: The nvm on CircleCI is https://github.com/coreybutler/nvm-windows, not https://github.com/nvm-sh/nvm, and the two aren't interchangeable. [nvm-windows has no functionality to install the latest version of a release line](coreybutler/nvm-windows#156) so we're forced to specify an exact version, which will need to be bumped manually in the future. This isn't great, but IMO it's no worse than the current situation, where we use whichever stale version of Node happens to be bundled with the Windows CircleCI executor. Changelog: [Internal] Differential Revision: D28896581 fbshipit-source-id: abf3b56a256f89374add1c01ae6b99a8ba234112

Summary: Pull Request resolved: #31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following #30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we pin a v14 release that is currently the most recent LTS version. NOTE: The nvm on CircleCI is https://github.com/coreybutler/nvm-windows, not https://github.com/nvm-sh/nvm, and the two aren't interchangeable. [nvm-windows has no functionality to install the latest version of a release line](coreybutler/nvm-windows#156) so we're forced to specify an exact version, which will need to be bumped manually in the future. This isn't great, but IMO it's no worse than the current situation, where we use whichever stale version of Node happens to be bundled with the Windows CircleCI executor. Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D28896581 fbshipit-source-id: a412376cf36054de49efa49866fe60dd964567c5

Summary: API of Jest transformers is changing in Jest 27. The new version of `jest/create-cache-key-function` handles both current versions of the API and the upcoming 27 API. Ref: jestjs/jest#10834  [Internal] [Changed] - Use version of `jest/create-cache-key-function` compatible with upcoming Jest v27 release Pull Request resolved: facebook#30637 Test Plan: I've tested locally that it works with both a `jest@latest` and `jest@next` release. Reviewed By: yungsters Differential Revision: D28807361 Pulled By: hramos fbshipit-source-id: 9d9ccb4d7f91b30bcbf3d28202bb74ce7499a91b

Summary: API of Jest transformers is changing in Jest 27. The new version of `jest/create-cache-key-function` handles both current versions of the API and the upcoming 27 API. Ref: jestjs/jest#10834  [Internal] [Changed] - Use version of `jest/create-cache-key-function` compatible with upcoming Jest v27 release Pull Request resolved: #30637 Test Plan: I've tested locally that it works with both a `jest@latest` and `jest@next` release. Reviewed By: yungsters Differential Revision: D28807361 Pulled By: hramos fbshipit-source-id: 9d9ccb4d7f91b30bcbf3d28202bb74ce7499a91b

Related with facebook/react-native#30637

* ⬆️ Bump jest from 26.6.3 to 27.0.4 Bumps [jest](https://github.com/facebook/jest) from 26.6.3 to 27.0.4. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v26.6.3...v27.0.4) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix Jest cache error Related with facebook/react-native#30637 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Cuesta <carloscuesta@me.com>

Summary: Pull Request resolved: facebook#31656 CircleCI's Windows executor currently ships with a pre-LTS release of Node v12, breaking our Windows jobs ([example](https://app.circleci.com/pipelines/github/facebook/react-native/9280/workflows/21e6e59c-d853-47a1-af62-1368c8ce10ce/jobs/203983)) following facebook#30637, ultimately due to jestjs/jest#10685 dropping support for non-LTS versions in the Node v12 release line. Luckily, the Windows executor [does ship with nvm](circleci/circleci-docs#3733) so we can use that to install a desired Node version. Rather than just pinning a later v12 release that is LTS, we pin a v14 release that is currently the most recent LTS version. NOTE: The nvm on CircleCI is https://github.com/coreybutler/nvm-windows, not https://github.com/nvm-sh/nvm, and the two aren't interchangeable. [nvm-windows has no functionality to install the latest version of a release line](coreybutler/nvm-windows#156) so we're forced to specify an exact version, which will need to be bumped manually in the future. This isn't great, but IMO it's no worse than the current situation, where we use whichever stale version of Node happens to be bundled with the Windows CircleCI executor. Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D28896581 fbshipit-source-id: a412376cf36054de49efa49866fe60dd964567c5

damdafayton · 2024-03-13T11:56:38Z

Facing same error with:
"jest": "^29.5.0",
"@testing-library/react-native": "^12.4.3",
"react": "^17.0.1",
"react-dom": "17.0.1",
"react-native": "0.64.4",

Error occurs if the file has "Image" component which does "require" a local asset.
Such as:
<Image source={require("../../assets/images/attachment.png")} style={{ height: 18, width: 18, marginBottom: 4, }} />

SimenB requested review from cpojer and hramos as code owners December 23, 2020 17:40

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2020

SimenB mentioned this pull request Mar 13, 2021

chore: update react-native example to 0.64 jestjs/jest#11190

Merged

thymikee approved these changes Mar 13, 2021

View reviewed changes

thymikee mentioned this pull request Mar 13, 2021

Upcoming v0.64.1 cherrypicks discussion react-native-community/releases#221

Closed

15 tasks

kelset mentioned this pull request May 5, 2021

Upcoming v0.64.2 cherrypicks discussion react-native-community/releases#224

Closed

14 tasks

SimenB changed the title ~~fix: update to @jest/create-cache-key-function@next~~ fix: update to @jest/create-cache-key-function@27 May 28, 2021

SimenB mentioned this pull request May 28, 2021

Version 27.0.0 and above break running snapshots and unit tests in react native project jestjs/jest#11474

Closed

thymikee mentioned this pull request May 31, 2021

TypeError: Cannot destructure property 'config' of 'options' as it is undefined. callstack/react-native-testing-library#743

Closed

SimenB added 2 commits May 31, 2021 11:22

fix: update to @jest/create-cache-key-function@next

872adb9

chore: use stable release

ed4eee6

SimenB force-pushed the jest-cache-key-next branch from 9a5bf2d to ed4eee6 Compare May 31, 2021 09:23

elicwhite added the Needs: React Native Team Attention label May 31, 2021

rickhanlonii approved these changes Jun 1, 2021

View reviewed changes

facebook-github-bot closed this in 2f477b1 Jun 2, 2021

facebook-github-bot added the Merged This PR has been merged. label Jun 2, 2021

SimenB deleted the jest-cache-key-next branch June 2, 2021 14:18

motiz88 mentioned this pull request Jun 4, 2021

Use Node v14 in Windows CircleCI jobs #31656

Closed

calintamas mentioned this pull request Jun 9, 2021

Bump jest from 26.6.3 to 27.0.4 calintamas/react-native-toast-message#202

Closed

xiongemi mentioned this pull request Jun 18, 2021

update nx version to 12.4.0 nrwl/nx-react-native#76

Merged

carloscuesta added a commit to carloscuesta/react-native-error-boundary that referenced this pull request Jun 20, 2021

Fix Jest cache error

017b065

Related with facebook/react-native#30637

dcarpenter31 mentioned this pull request Feb 5, 2022

Update all dependencies Peer-Stevens/peer#247

Merged

1 task

SimenB mentioned this pull request Apr 28, 2022

fix(jest-expo): update @jest/create-cache-key-function to match upstream expo/expo#17240

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update to @jest/create-cache-key-function@27 #30637

fix: update to @jest/create-cache-key-function@27 #30637

SimenB commented Dec 23, 2020 •

edited

Loading

pull-bot commented Dec 23, 2020 •

edited

Loading

thymikee left a comment

SimenB commented May 25, 2021

DoctorJohn commented May 29, 2021

thymikee commented May 31, 2021

rickhanlonii left a comment

facebook-github-bot commented Jun 1, 2021

facebook-github-bot commented Jun 2, 2021

damdafayton commented Mar 13, 2024 •

edited

Loading

fix: update to @jest/create-cache-key-function@27 #30637

fix: update to @jest/create-cache-key-function@27 #30637

Conversation

SimenB commented Dec 23, 2020 • edited Loading

Summary

Changelog

Test Plan

pull-bot commented Dec 23, 2020 • edited Loading

thymikee left a comment

Choose a reason for hiding this comment

SimenB commented May 25, 2021

DoctorJohn commented May 29, 2021

thymikee commented May 31, 2021

rickhanlonii left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Jun 1, 2021

facebook-github-bot commented Jun 2, 2021

damdafayton commented Mar 13, 2024 • edited Loading

SimenB commented Dec 23, 2020 •

edited

Loading

pull-bot commented Dec 23, 2020 •

edited

Loading

damdafayton commented Mar 13, 2024 •

edited

Loading