Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -javadoc.jar, -sources.jar from NPM package validation #30686

Closed
wants to merge 1 commit into from

Conversation

dulmandakh
Copy link
Contributor

Summary

In a4d8632, I removed javadoc.jar, and sources.jar generation, but forgot to change artifact validation for NPM publish. This PR removes javadoc.jar and sources.jar from validation.

Changelog

[Internal] [Changed] - remove javadoc.jar, sources.jar from NPM package validation

Test Plan

publish_npm_package CI job must succeed.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jan 5, 2021
@dulmandakh dulmandakh changed the title remove -javadoc.jar, -sources.jar from checks remove -javadoc.jar, -sources.jar from NPM package validation Jan 5, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7a9e4ba

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,898,886 -369
android hermes armeabi-v7a 8,392,350 -962
android hermes x86 9,388,134 -416
android hermes x86_64 9,333,802 -761
android jsc arm64-v8a 10,354,231 -372
android jsc armeabi-v7a 9,830,802 -959
android jsc x86 10,404,978 -423
android jsc x86_64 10,990,921 -745

Base commit: 7a9e4ba

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 6, 2021
@facebook-github-bot
Copy link
Contributor

@fkgozali merged this pull request in dc9132e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants