WIP: bump okhttp to 4.x #30694
WIP: bump okhttp to 4.x #30694
Conversation
facebook-github-bot
added
CLA Signed
Base commit: d3a3ce8 |
|
Thanks for doing his @dulmandakh. I've searched-up the repo for usages of internal OkHttp APIs and found one at RequestBodyUtil:L135. It is a call to Util.closeQuietly, which we can easily replicate. Do you think it is something that we can fix in this PR? |
|
Any help is welcome. They say that they made some APIs final thus having problems with mocking. |
|
Alright, do you want me to push to this branch then? I will take a look at it later today |
|
Also, how do you usually test changes like this? (dep upgrades for example) |
|
First of we need to make tests pass, but with this change test_android is failing. Please feel free work which ever way works for you |
|
@dulmandakh I think that we can remove TLSSocketFactory
|
|
Hey folks. I've picked up this branch to fix broken tests and created a follow-up PR here: #31084. Feel free to review and leave comments if any. |
|
closing in favor of #31084 |
Summary: Extends #30694 to fix tests. OkHttp v4 was released almost a year ago. Even though v3 is still receiving security and bug fixes, most of the new improvements and features are landing in v4. This PR bumps OkHttp from v3 to v4 and addresses backward-incompatible changes. Side effects of this upgrade: - OkHttp v4 depends on Kotlin's standard library, so react-native will have a transitive dependency on it. - The dex method count of test apk has exceeded the maximum, so multidexing had to be enabled for android tests. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Changed] - Bumping OkHttp from v3 to v4. Pull Request resolved: #31084 Test Plan: Automated (relying on the test suite) and manual testing. Reviewed By: fkgozali Differential Revision: D27597430 Pulled By: ShikaSD fbshipit-source-id: 967379b41c2bcd7cfd4083f65059f5da467b8a91
Summary
Bump OkHTTP to 4.x, which uses Kotlin. This
https://square.github.io/okhttp/upgrading_to_okhttp_4/
Changelog
[Android] [Changed] - Bump OkHTTP to 4.x,
Test Plan