Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RefreshControl layout when removed from window #31024

Closed
wants to merge 2 commits into from
Closed

Fix RefreshControl layout when removed from window #31024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1dc453
Fix RefreshControl layout when removed from window
janicduplessis Feb 21, 2021
376cee6
Update RCTRefreshControl.m
janicduplessis Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions React/Views/RefreshControl/RCTRefreshControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ - (void)layoutSubviews
_isInitialRender = false;
}

- (void)didMoveToWindow
{
janicduplessis marked this conversation as resolved.
Show resolved Hide resolved
[super didMoveToWindow];

// Since iOS 14 there seems to be a bug where refresh control becomes
// visible if the view gets removed from window then added back again.
// Calling endRefreshing fixes the layout.
if (!_currentRefreshingState) {
[super endRefreshing];
}
}

- (void)beginRefreshingProgrammatically
{
UInt64 beginRefreshingTimestamp = _currentRefreshingStateTimestamp;
Expand Down