Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in RCTConvert.m #31067

Closed
wants to merge 1 commit into from
Closed

Fix typo in RCTConvert.m #31067

wants to merge 1 commit into from

Conversation

eltociear
Copy link
Contributor

@eltociear eltociear commented Feb 27, 2021 •
edited
Loading

Summary

seperated -> separated

Changelog

[Internal] [Fixed] - Fixed typo in comment

Test Plan

NONE

@eltociear
Fix typo in RCTConvert.m
6fba165 
seperated -> separated
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f7d006e

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,902,607 +0
android hermes armeabi-v7a 8,399,785 +0
android hermes x86 9,391,516 +0
android hermes x86_64 9,335,757 +0
android jsc arm64-v8a 10,636,636 +0
android jsc armeabi-v7a 10,116,910 +0
android jsc x86 10,687,040 +0
android jsc x86_64 11,271,548 +0

Base commit: f7d006e

@facebook-github-bot
Copy link
Contributor

@sota000 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@sota000 sota000 self-assigned this Aug 7, 2021
@facebook-github-bot
Copy link
Contributor

@sota000 merged this pull request in ecd6927.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shergin shergin Awaiting requested review from shergin

Assignees

@sota000 sota000

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eltociear @analysis-bot @facebook-github-bot @sota000