-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility/button test #31189
Accessibility/button test #31189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslint
found some issues. Runyarn lint --fix
to automatically fix problems.
Base commit: a15a46c |
Base commit: feebfe1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslint
found some issues. Runyarn lint --fix
to automatically fix problems.
@lunaleaps @kacieb Can you please review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit in terms of setting expectations, otherwise looks good!
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks so much for writing these tests!
They can be simplified a bit - see my comment on another pull request about the same thing here.
You can follow the same test structure as this commit.
@huzaifaaak I'll wait for your response from @kacieb's comment before landing. |
@lunaleaps I have updated the test structure |
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@lunaleaps merged this pull request in b5e649f. |
Summary
This PR aims to add test's for button.
Snapshot test for PR #31001 . This would make sure
accessibilityState
is properly set.Changelog
[General] [Added] - Test's for button
Test Plan
npm test
to run the test's.Since the disabled prop of button has precedence over
accessibilityState.disabled
the test's will make sure it remains this way.