-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added talkback support for TouchableNativeFeedback accessibility: disabled prop #31224
Conversation
Hi @kyamashiro! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 4cc3aa8 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Base commit: 4cc3aa8 |
Thank you @kyamashiro for submitting this PR to help make React Native more accessible! I've added your PR to our project board. |
@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Thank you @kyamashiro for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? |
@amarlette |
Summary
Issue #30952
Add talkback support for TouchableNativeFeedback component.
Changelog
[Android] [Changed] - TouchableNativeFeedback: sync disabled prop with accessibilityState
Test Plan
I have checked that talkback and disabled works properly on the actual device(Pixel4a Android11).