Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rn_codegen BUCK macro #31340

Closed
wants to merge 1 commit into from
Closed

Conversation

RSNara
Copy link
Contributor

@RSNara RSNara commented Apr 12, 2021

Summary: Changelog: [Internal]

Differential Revision: D27669950

@facebook-github-bot facebook-github-bot added p: Facebook Partner: Facebook Partner CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Apr 12, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27669950

@pull-bot
Copy link

pull-bot commented Apr 12, 2021

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against a2827e3

@analysis-bot
Copy link

analysis-bot commented Apr 12, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0cab446

Summary:
Pull Request resolved: facebook#31340

Changelog: [Internal]

Differential Revision: D27669950

fbshipit-source-id: 071f659f2544b06d583878a0a345539f20fd3390
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D27669950

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,852,001 +29,419
android hermes armeabi-v7a 8,373,503 +15,765
android hermes x86 9,308,702 +29,224
android hermes x86_64 9,251,542 +34,869
android jsc arm64-v8a 10,582,930 +29,428
android jsc armeabi-v7a 10,087,528 +15,763
android jsc x86 10,601,126 +29,218
android jsc x86_64 11,184,237 +34,863

Base commit: 0cab446

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in e1eb938.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 15, 2021
Kudo pushed a commit to Kudo/react-native that referenced this pull request Apr 16, 2021
Summary:
Pull Request resolved: facebook#31340

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D27669950

fbshipit-source-id: 3129d87da8f74d896c0b9e82799b8896b3ed7635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants