fix#29319 - ios dismiss modal

[intergalacticspacehighway]

This PR aims to resolve iOS can't dismiss Modal on swipe gesture.
#29319

Summary

When modal presentationStyle is pageSheet, iOS allows to dismiss the modal using swipe gesture. This PR adds support for that feature

Changelog

[iOS] [Added] - Support for onRequestClose for iOS Modal component.

Test Plan

• If onRequestClose updates the visibility state, modal will be closed.

<Modal
    visible={visible}
    animationType="slide"
    presentationStyle="pageSheet"
    onRequestClose={dismiss}>
</Modal>

Screen.Recording.2021-05-10.at.4.56.54.AM.mov

Notes

• In this PR, only support for partial drag is added. i.e. user can't drag the modal up and down completely. I added full user dragging but reverted in this commit to support controllable onRequestClose. If someone has any suggestion to have full draggable support + controllable onRequestClose, please let me know.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: ae4946f

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,986,729	+0
android	hermes	armeabi-v7a	8,493,977	+0
android	hermes	x86	9,439,010	+0
android	hermes	x86_64	9,380,773	+0
android	jsc	arm64-v8a	10,605,129	+0
android	jsc	armeabi-v7a	10,105,423	+0
android	jsc	x86	10,624,145	+0
android	jsc	x86_64	11,207,819	+0

Base commit: ae4946f

[oarsoy]

When this will be merged? It doesn't make any sense.

[facebook-github-bot]

@sammy-SC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[sammy-SC]

@intergalacticspacehighway awesome! Thank you for working on this.

We might need to change documentation for Modal onRequestClose

[zhahaoyu]

Hi @sammy-SC @intergalacticspacehighway How can we merge this PR? this is open for a couple months now.

[intergalacticspacehighway]

@sammy-SC Updated the docs for the same. Let me know if any changes are needed! :)

[zhahaoyu]

@feedthejim Could you review this and merge?

[henrymoulton]

@sammy-SC thank you for previously taking a look at this. It looks like @intergalacticspacehighway updated the docs, is there anything else outstanding?

[facebook-github-bot]

@sammy-SC merged this pull request in c29ec46.