Fix keyboardDismissMode="on-drag" on Android #31943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
Contributor
Base commit: 8a8a532 |
Base commit: 8a8a532 |
facebook-github-bot
added
the
Shared with Meta
|
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@yungsters merged this pull request in 7edf927. |
zhxlp
pushed a commit
to zhxlp/react-native
that referenced
this pull request
Aug 1, 2023
Summary: Fixes facebook#23364 The current logic using `_isTouching` does not work because `_handleTouchCancel` is always called before scroll events begin. This means `_isTouching` is always false. To fix it I moved the logic to `_handleScrollBeginDrag` which is only called once when scroll drag beings. This accomplishes the expected behavior and is better than keeping it in onScroll where it would be called for each scroll event. ## Changelog [Android] [Fixed] - Fix keyboardDismissMode="on-drag" on Android Pull Request resolved: facebook#31943 Test Plan: Tested in an app that on-drag does not work before and works after this patch. Reviewed By: sshic Differential Revision: D30674276 Pulled By: yungsters fbshipit-source-id: aa0bd605809fa01518f70fbf323c06e32c76ed1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #23364
The current logic using
_isTouchingdoes not work because_handleTouchCancelis always called before scroll events begin. This means_isTouchingis always false. To fix it I moved the logic to_handleScrollBeginDragwhich is only called once when scroll drag beings. This accomplishes the expected behavior and is better than keeping it in onScroll where it would be called for each scroll event.Changelog
[Android] [Fixed] - Fix keyboardDismissMode="on-drag" on Android
Test Plan
Tested in an app that on-drag does not work before and works after this patch.