-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACCESS_MEDIA_LOCATION
permission
#32282
Conversation
Hi @Skrilltrax! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 3516090 |
Base commit: 3516090 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Thanks for the PR @Skrilltrax. I've imported the PR, I believe we should be good merging this 👍 |
Sorry but this is taking a bit longer than usual. We had some failures on the internal CI that prevented this form landing. We should be good to go. I'll be back next week worst case and will merge this by then. |
Hey, no issues. Thanks for the update 👍 |
This pull request was successfully merged by @Skrilltrax in 79db483. When will my fix make it into a release? | Upcoming Releases |
Summary
This PR adds
ACCESS_MEDIA_LOCATION
permission to the PermissionsAndroid library. It fixes #31953.It's a
dangerous
permission added in API level 29.https://developer.android.com/reference/android/Manifest.permission#ACCESS_MEDIA_LOCATION
Changelog
[Android] [Added] - Add ACCESS_MEDIA_LOCATION permission to PermisionsAndroid library.
Test Plan