feat: add getAll function to formdata #32444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
react-native-bot
added
the
Type: Enhancement
Base commit: 28064ee |
|
@sshic has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@sshic any updates? |
luluwu2032
reviewed
Mar 24, 2022
luluwu2032
reviewed
Mar 24, 2022
|
Also can you fix the failed checks @matinzd? |
matinzd
force-pushed
the
feat/add_getall_formdata
branch
from
0c33daa
to
1c21dd7
Compare
matinzd
changed the title
Base commit: 28064ee |
The two builds failures are unrelated and are currently broken on main. We're looking into them and can be disregarded here. |
|
@cortinico Any update? |
lunaleaps
approved these changes
Mar 29, 2022
|
@matinzd those 2 failures were related to an Android issue that is now fixed on master. Don't you mind rebasing? |
matinzd
force-pushed
the
feat/add_getall_formdata
branch
5 times, most recently
from
e923254
to
766b627
Compare
The getAll() method of the FormData interface returns all the values associated with a given key from within a FormData object. Reference: https://developer.mozilla.org/en-US/docs/Web/API/FormData
matinzd
force-pushed
the
feat/add_getall_formdata
branch
from
766b627
to
bdf429f
Compare
Merged
12 tasks
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @matinzd in d05a5d1. When will my fix make it into a release? | Upcoming Releases |
typescript-bot
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jun 26, 2022
…rmData by @matinzd * feat: add getAll function type to formData Reference: facebook/react-native#32444 * tests: add getAll to tests * tests: fix
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: The getAll() method of the [FormData](https://developer.mozilla.org/en-US/docs/Web/API/FormData) interface returns all the values associated with a given key from within a FormData object. ## Changelog [General] [Added] - Add getAll function to FormData class for getting all parts containing that key. This is also available in web API. Pull Request resolved: facebook#32444 Test Plan: New test added in FormData-test.js Reviewed By: lunaleaps Differential Revision: D31798633 Pulled By: cortinico fbshipit-source-id: ef29bb54e930532a671adbe707be8d1a64ff0d82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The getAll() method of the FormData interface returns all the values associated with a given key from within a FormData object.
Changelog
[General] [Added] - Add getAll function to FormData class for getting all parts containing that key. This is also available in web API.
Test Plan
New test added in FormData-test.js