Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include Facebook license on users codegen'd code #32840

Closed
wants to merge 1 commit into from

Commits on Jan 7, 2022

  1. Do not include Facebook license on users codegen'd code (facebook#32840)

    Summary:
    Pull Request resolved: facebook#32840
    
    Closes facebook#31516
    I've cherry-picked the original PR that had merge conficts + updated all
    the headers as the one for the TurboModule generators were not handled.
    
    Original Commit Message from acoates
    
    The codegen generates a Facebook copyright notice at the top of the generated files.
    
    While this might make sense on the core files, this codegen will be run on external components too.
    The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project.
    I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments
    saying the file was codegen'd and so the file shouldn't be manually edited.
    Open to suggestions on what the comment header should say.
    
    Changelog:
    [General] [Changed] - Do not include Facebook license on users codegen'd code
    
    Differential Revision: D33455176
    
    fbshipit-source-id: 5bcc73155d79ee7128726ec040bb6a5f94623baf
    cortinico authored and facebook-github-bot committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    662dc1e View commit details
    Browse the repository at this point in the history