Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RN Version Expected Structure #32892

Closed
wants to merge 1 commit into from

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Jan 14, 2022

Summary

Current syntax options for RN version values break Windows. Following change to nightly build format to be 0.0.0-X-X-X, prerelease value is now a string (X-X-X).

microsoft/react-native-windows#9223

Changelog

[General] [Fixed] - Fix RN version syntax to match new nightly build structure.

Test Plan

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 14, 2022
@analysis-bot
Copy link

analysis-bot commented Jan 15, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 48f6967
Branch: main

@analysis-bot
Copy link

analysis-bot commented Jan 15, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,291,545 -5,845
android hermes armeabi-v7a 7,622,109 -12,181
android hermes x86 8,761,911 -8,828
android hermes x86_64 8,701,079 -6,855
android jsc arm64-v8a 9,680,535 -102,750
android jsc armeabi-v7a 8,667,782 -100,597
android jsc x86 9,636,409 -112,823
android jsc x86_64 10,233,174 -112,141

Base commit: 48f6967
Branch: main

@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @chiaramooney in 3d1d4ee.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants