Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SoLoader to 0.10.3 #32922

Closed
wants to merge 1 commit into from
Closed

Bump SoLoader to 0.10.3 #32922

wants to merge 1 commit into from

Conversation

osartun
Copy link
Contributor

@osartun osartun commented Jan 19, 2022

Closes #32325
Closes #32735

Summary

There are various crashes related to the SoLoader (example: #32325, #32735, facebook/SoLoader#74, facebook/SoLoader#84) which seem to get resolved by upgrading to v0.10.3.

The upgrade was already done in …/soloader/BUCK (58532ed) but the SO_LOADER_VERSION gradle variable was still on v0.10.1.

Changelog

[Android] [Changed] - Bump Soloader to 0.10.3

Test Plan

This is my very first RN PR and unfortunately I have troubles running the tests. The proposed tests use Buck anyway and the Buck file was already upgraded so those tests wouldn't change presumably. And I can't get the rn-tester to run.

@facebook-github-bot
Copy link
Contributor

Hi @osartun!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@react-native-bot react-native-bot added the Platform: Android Android applications. label Jan 19, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4509679
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,295,247 +3,618
android hermes armeabi-v7a 7,632,372 +3,615
android hermes x86 8,767,981 +3,606
android hermes x86_64 8,704,891 +3,611
android jsc arm64-v8a 9,681,742 +2,800
android jsc armeabi-v7a 8,675,563 +2,807
android jsc x86 9,639,994 +2,806
android jsc x86_64 10,234,499 +2,812

Base commit: 4509679
Branch: main

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 19, 2022
@facebook-github-bot
Copy link
Contributor

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @osartun in f45889e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 20, 2022
@osartun osartun deleted the bump-so-loader branch January 20, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
4 participants