-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump SoLoader to 0.10.3 #32922
Bump SoLoader to 0.10.3 #32922
Conversation
Hi @osartun! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: 4509679 |
Base commit: 4509679 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @osartun in f45889e. When will my fix make it into a release? | Upcoming Releases |
Closes #32325
Closes #32735
Summary
There are various crashes related to the SoLoader (example: #32325, #32735, facebook/SoLoader#74, facebook/SoLoader#84) which seem to get resolved by upgrading to v0.10.3.
The upgrade was already done in
…/soloader/BUCK
(58532ed) but theSO_LOADER_VERSION
gradle variable was still on v0.10.1.Changelog
[Android] [Changed] - Bump Soloader to 0.10.3
Test Plan
This is my very first RN PR and unfortunately I have troubles running the tests. The proposed tests use Buck anyway and the Buck file was already upgraded so those tests wouldn't change presumably. And I can't get the
rn-tester
to run.