Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR #33038

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
While rolling out RN 0.68.x we noticed that libhermes.so and libjsc.so were included
inside the final .aar we publish to NPM. This forced users (on both old or new arch) to
specify a pickFirst directive inside their packaging option (which is unpractical and
risky as the two .so might not be compatible each other if they're coming from
different Hermes/JSC versions).

Changelog:
[Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR

Differential Revision: D33979107

…id AAR

Summary:
While rolling out RN 0.68.x we noticed that `libhermes.so` and `libjsc.so` were included
inside the final .aar we publish to NPM. This forced users (on both old or new arch) to
specify a `pickFirst` directive inside their packaging option (which is unpractical and
risky as the two .so might not be compatible each other if they're coming from
different Hermes/JSC versions).

Changelog:
[Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR

Differential Revision: D33979107

fbshipit-source-id: 69b9271ac4c28a69a5abc49866685281bd41abd9
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Feb 3, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33979107

@react-native-bot react-native-bot added Bug Platform: Android Android applications. labels Feb 3, 2022
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 4cbcb7a
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,120,900 -182,345
android hermes armeabi-v7a 7,720,882 +80,153
android hermes x86 8,490,389 -287,762
android hermes x86_64 8,442,349 -272,547
android jsc arm64-v8a 9,787,603 +0
android jsc armeabi-v7a 8,772,457 +0
android jsc x86 9,753,689 +0
android jsc x86_64 10,349,733 +0

Base commit: 4cbcb7a
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cortinico in fa85417.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 3, 2022
ShikaSD pushed a commit that referenced this pull request Feb 3, 2022
…id AAR (#33038)

Summary:
Pull Request resolved: #33038

While rolling out RN 0.68.x we noticed that `libhermes.so` and `libjsc.so` were included
inside the final .aar we publish to NPM. This forced users (on both old or new arch) to
specify a `pickFirst` directive inside their packaging option (which is unpractical and
risky as the two .so might not be compatible each other if they're coming from
different Hermes/JSC versions).

Changelog:
[Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR

Reviewed By: ShikaSD

Differential Revision: D33979107

fbshipit-source-id: 0b71d59f210b8bc9903cd0f30ed6e2120aab99e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants