build(deps): Bump android Appcompat to 1.4.1 #33072

gabrieldonadel · 2022-02-09T02:36:35Z

Summary

Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.

Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to #33065)

Closes #31620

Changelog

[Android] [Changed] - Bump android Appcompat to 1.4.1

Test Plan

Use ./scripts/test-manual-e2e.sh to test both RNTester and a new app

gabrieldonadel · 2022-02-09T02:41:19Z

ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java

@@ -323,7 +323,7 @@ public View getContentView() {
  }

  public boolean isShowing() {
-    return mDialog.isShowing();
+    return mDialog != null && mDialog.isShowing();


RNTester was crashing without this extra check

analysis-bot · 2022-02-09T03:03:40Z

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 172f990
Branch: main

analysis-bot · 2022-02-09T03:13:21Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,188,751	+68,175
android	hermes	armeabi-v7a	7,790,036	+69,059
android	hermes	x86	8,559,456	+68,782
android	hermes	x86_64	8,511,320	+68,318
android	jsc	arm64-v8a	9,857,741	+70,108
android	jsc	armeabi-v7a	8,843,894	+70,978
android	jsc	x86	9,825,019	+70,689
android	jsc	x86_64	10,420,988	+70,237

Base commit: 172f990
Branch: main

gabrieldonadel · 2022-02-09T03:56:46Z

@cortinico I believe this commit cd79317 broke CI, in particular the test_android_template workflow https://app.circleci.com/pipelines/github/facebook/react-native/12051/workflows/2592c9f6-217f-4595-9981-82f4097fecf3/jobs/234753

gabrieldonadel · 2022-02-09T04:00:19Z

Ohh never mind, I guess you already have a PR fixing this

facebook-github-bot · 2022-02-09T13:32:25Z

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cortinico · 2022-02-09T13:42:58Z

Ohh never mind, I guess you already have a PR fixing this

Yup you're right. We're working on it, hopefully it will be out in the next hours. Sorry for the disruption 👍

ShikaSD · 2022-02-09T13:56:41Z

Hi, thanks for upgrading it, do you mind updating the BUCK file for the dependency as well?

react-native/ReactAndroid/src/main/third-party/android/androidx/BUCK

Line 538 in 369a7ab

url = "mvn:androidx.appcompat:appcompat:aar:1.0.2",

gabrieldonadel · 2022-02-09T14:03:23Z

Hi, thanks for upgrading it, do you mind updating the BUCK file for the dependency as well?

react-native/ReactAndroid/src/main/third-party/android/androidx/BUCK

Line 538 in 369a7ab

url = "mvn:androidx.appcompat:appcompat:aar:1.0.2",

Sure @ShikaSD, I can update that. My only question is regarding the sha1 value, should I run some command that updates this automatically or do I need to get it from somewhere else?

ShikaSD · 2022-02-09T14:12:36Z

Should I run some command that updates this automatically or do I need to get it from somewhere else?

It can be retrieved from google maven repo, I don't think we have any command that upgrades it automatically. If you struggle to find the hash, you can upgrade the version and then wait for the CI to fail, it should have a new hash there.

gabrieldonadel · 2022-02-09T14:17:04Z

It can be retrieved from google maven repo, I don't think we have any command that upgrades it automatically. If you struggle to find the hash, you can upgrade the version and then wait for the CI to fail, it should have a new hash there.

Ohh got it! Thanks @ShikaSD

gabrieldonadel · 2022-02-09T14:25:54Z

Hi, thanks for upgrading it, do you mind updating the BUCK file for the dependency as well?

Done 😄

facebook-github-bot · 2022-02-09T14:47:18Z

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ShikaSD · 2022-02-09T14:57:48Z

I think CI is broken after the latest commit, it cannot find some androidx classes:

stderr: : warning: unknown enum constant androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP_PREFIX

/root/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.java:22: error: cannot access androidx.core.widget.TintableCompoundDrawablesView
    mTextView.setLayoutParams(

cortinico · 2022-02-09T17:13:19Z

#33068 has been marged. You should be able to rebase and get a green CI from that 👍

gabrieldonadel · 2022-02-10T00:56:29Z

I think CI is broken after the latest commit, it cannot find some androidx classes:

Yeah, I had quite a hard time installing BUCK in my machine to investigate this because I'm using an M1 mac, I finally got it working, I'll start investigating why this is falling now

gabrieldonadel · 2022-02-10T02:43:31Z

I think CI is broken after the latest commit, it cannot find some androidx classes:

stderr: : warning: unknown enum constant androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP_PREFIX

/root/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.java:22: error: cannot access androidx.core.widget.TintableCompoundDrawablesView
    mTextView.setLayoutParams(

Any suggestion on how to fix this @ShikaSD @cortinico ?

I believe the cannot access androidx.core.widget.TintableCompoundDrawablesView error is build caused by some sort of version mismatch in the BUCK file, but I can't quite figure it out

cortinico · 2022-02-10T12:29:35Z

Any suggestion on how to fix this @ShikaSD @cortinico ?

Yup, you'll need to add to the BUCK file you attached the following rule:

fb_native.android_prebuilt_aar(
    name = "appcompat-resources-binary",
    aar = ":appcompat-resources-binary-aar",
)

and edit the "appcompat" target with:

fb_native.android_library(
    name = "appcompat",
    visibility = ["PUBLIC"],
    exported_deps = [
        ":annotation",
        ":appcompat-binary",
+       ":appcompat-resource-binary",
        ":collection",
        ":core",
        ":cursoradapter",
        ":fragment",
        ":legacy-support-core-utils",
        ":vectordrawable",
        ":vectordrawable-animated",
    ],
)

If you see the other targets have similar definition

gabrieldonadel · 2022-02-10T16:07:17Z

Yup, you'll need to add to the BUCK file you attached the following rule

Adding that actually ends up breaking another place now

gabrieldonadel · 2022-02-10T17:09:40Z

Yup, you'll need to add to the BUCK file you attached the following rule

Adding that actually ends up breaking another place now

I managed to fix this by bumping android:core version as well

facebook-github-bot · 2022-02-10T17:18:29Z

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

react-native-bot · 2022-02-10T18:10:04Z

This pull request was successfully merged by @gabrieldonadel in 6b61995.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1. Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to facebook#33065) Closes facebook#31620 ## Changelog [Android] [Changed] - Bump android Appcompat to 1.4.1 Pull Request resolved: facebook#33072 Test Plan: Use `./scripts/test-manual-e2e.sh` to test both RNTester and a new app Reviewed By: cortinico Differential Revision: D34107105 Pulled By: ShikaSD fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

View reviewed changes

react-native-bot added the Platform: Android Android applications. label Feb 9, 2022

gabrieldonadel mentioned this pull request Feb 9, 2022

WIP: Appcompat 1.3.0 #31620

Closed

gabrieldonadel force-pushed the feat/bump-appcompat branch from 3bb403c to 9ab8271 Compare February 9, 2022 03:38

gabrieldonadel force-pushed the feat/bump-appcompat branch from 9ab8271 to 6a84ccc Compare February 9, 2022 12:03

gabrieldonadel force-pushed the feat/bump-appcompat branch from ee40a15 to 99c9059 Compare February 9, 2022 17:28

cortinico approved these changes Feb 9, 2022

View reviewed changes

gabrieldonadel added 3 commits February 9, 2022 21:59

build(deps): Bump android Appcompat to 1.4.1

8f70695

build(deps): Bump BUCK Appcompat to 1.4.1

af06c5c

build(deps): Add appcompat-resources to BUCK

252034f

gabrieldonadel force-pushed the feat/bump-appcompat branch from 99c9059 to 252034f Compare February 10, 2022 00:59

fix: Add missing appcompact-resources to BUCK

babeb10

fix: Bump androidx:core on BUCK

c8230be

gabrieldonadel requested a review from cortinico February 10, 2022 17:15

facebook-github-bot closed this in 6b61995 Feb 10, 2022

gabrieldonadel deleted the feat/bump-appcompat branch February 10, 2022 18:06

react-native-bot added the Merged This PR has been merged. label Feb 10, 2022

This was referenced Jul 7, 2022

Cherry-pick: Bump android Appcompat to 1.4.1 microsoft/react-native-macos#1236

Merged

Merge pull request #1236 from rasaha91/cherry-pick-appcompat-upgrade microsoft/react-native-macos#1237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): Bump android Appcompat to 1.4.1 #33072

build(deps): Bump android Appcompat to 1.4.1 #33072

gabrieldonadel commented Feb 9, 2022 •

edited by cortinico

Loading

gabrieldonadel Feb 9, 2022

analysis-bot commented Feb 9, 2022 •

edited

Loading

analysis-bot commented Feb 9, 2022 •

edited

Loading

gabrieldonadel commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

facebook-github-bot commented Feb 9, 2022

cortinico commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

facebook-github-bot commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

cortinico commented Feb 9, 2022

gabrieldonadel commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

cortinico commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

facebook-github-bot commented Feb 10, 2022

react-native-bot commented Feb 10, 2022

build(deps): Bump android Appcompat to 1.4.1 #33072

build(deps): Bump android Appcompat to 1.4.1 #33072

Conversation

gabrieldonadel commented Feb 9, 2022 • edited by cortinico Loading

Summary

Changelog

Test Plan

gabrieldonadel Feb 9, 2022

Choose a reason for hiding this comment

analysis-bot commented Feb 9, 2022 • edited Loading

analysis-bot commented Feb 9, 2022 • edited Loading

gabrieldonadel commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

facebook-github-bot commented Feb 9, 2022

cortinico commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

gabrieldonadel commented Feb 9, 2022

facebook-github-bot commented Feb 9, 2022

ShikaSD commented Feb 9, 2022

cortinico commented Feb 9, 2022

gabrieldonadel commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

cortinico commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

gabrieldonadel commented Feb 10, 2022

facebook-github-bot commented Feb 10, 2022

react-native-bot commented Feb 10, 2022

gabrieldonadel commented Feb 9, 2022 •

edited by cortinico

Loading

analysis-bot commented Feb 9, 2022 •

edited

Loading

analysis-bot commented Feb 9, 2022 •

edited

Loading